Repository navigation
[pull] main from firecrawl:main - #462
Merged
Merged
Conversation
…ns (#4753) * fix(api): make browser session DELETE idempotent for destroyed sessions DELETE /v2/browser/:id and DELETE /v2/scrape/:jobId/interact always asked the browser service to release the browser, also when the row was already destroyed. The browser service no longer knows a released browser, so the call failed and the API returned 502 "Browser session release was not confirmed." for a session that was already gone. Now a destroyed row returns 200 at once. The browser service is not called, and nothing is billed again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GtTdaBf2tczu67ykS7Aor6 * fix(api): release the live interact session when a scrape has several rows scrape_id is not unique in browser_sessions. Two concurrent interact calls on one scrape can each insert a row. getBrowserSessionFromScrape used LIMIT 1 with no order, so DELETE /v2/scrape/:jobId/interact could pick a destroyed row, return 200, and leave the active row running. The helper now reads the rows for the scrape, newest first, and returns the newest row that is not destroyed. It returns the newest destroyed row only when no live row exists. Also run the browser session DELETE unit tests in CI. The self-hosted suite has no browser service, so snips cannot cover this path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GtTdaBf2tczu67ykS7Aor6 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )