-
Notifications
You must be signed in to change notification settings - Fork 337
Support Service Account Authentication #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aurelian-Shuttleworth
wants to merge
1
commit into
insanum:main
Choose a base branch
from
Aurelian-Shuttleworth:feature/service-account
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
|
|
||
| import pytest | ||
| from gcalcli.gcal import GoogleCalendarInterface | ||
| from gcalcli import auth | ||
|
|
||
| def test_service_account_loading(PatchedGCalI, monkeypatch): | ||
| # Mock auth.load_service_account to return a dummy | ||
| mock_creds = "DUMMY_CREDS" | ||
|
|
||
| mock_called = False | ||
| def mock_load(path): | ||
| nonlocal mock_called | ||
| mock_called = True | ||
| assert path == "/tmp/fake-key.json" | ||
| return mock_creds | ||
|
|
||
| monkeypatch.setattr(auth, 'load_service_account', mock_load) | ||
|
|
||
| # Initialize GCal with service_account option | ||
| # Note: PatchedGCalI uses default_options fixture usually, we override | ||
| gcal = PatchedGCalI(service_account="/tmp/fake-key.json") | ||
|
|
||
| # Trigger auth load (lazy init might not have done it yet if cache existed? | ||
| # But PatchedGCalI stubs things out. Let's explicitly call _load_credentials or access) | ||
| gcal._load_credentials() | ||
|
|
||
| assert mock_called | ||
| assert gcal.credentials == mock_creds | ||
|
|
||
| def test_service_account_skips_oauth_cache(PatchedGCalI, monkeypatch, tmp_path): | ||
| # Setup a fake oauth cache file | ||
| # PatchedGCalI mocks data_file_path_stub. We need to create the file where it expects. | ||
| # But checking if the file is IGNORED is the goal. | ||
|
|
||
| # Mock load_service_account | ||
| monkeypatch.setattr(auth, 'load_service_account', lambda p: "SA_CREDS") | ||
|
|
||
| gcal = PatchedGCalI(service_account="/tmp/key.json") | ||
| gcal._load_credentials() | ||
|
|
||
| assert gcal.credentials == "SA_CREDS" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.