Repository navigation
Remove unnecessary "rows" property from Redux Store #314
Description
"Rows" property is being loaded at Lab Record Import and Electronic Pharmacy Stock Record index, though they aren't required in that context. Rows are only required when accessing the details of a LRI.
Removing them from Redux Store at LRI index level will probably lead to potential gains in terms of memory consumption, because rows objects are big in size.
Activity
[-]Remove unnecessary "rows" property from Redux Store[/-][+]Remove unnecessary LRI "rows" property from Redux Store[/+][-]Remove unnecessary LRI "rows" property from Redux Store[/-][+]Remove unnecessary "rows" property from Redux Store[/+]lmatayoshi commentedon Nov 17, 2020
@mmuller a couple of this here:
These changes modify the way the required data in the LabRecords and ElectronicPharmacyStockRecords lists is stored in memory. You shouldn't take notice of any of these changes unless something got broken.
In order to accomplish that, I had to modify the way all entities were querying their data. So the mission is to verify that changes don't produce any undesirable effect over the lists: Sites, LabRecords, ElectronicPharmacyStockRecords, Patients, PatientEntries, Antibiotics and AntibioticConsumptionStats.
We have to check that all the lists still show the correct data and that it remains properly scoped. For example, that the right LabRecords are shown for a given
site, or that the rightAntibioticConsumptionStatsare shown for a givenantibioticand a givensite.Finally, an additional check is that filters in
Siteslist andAntibioticsstill work properly. And the same when creating new instances: Antibiotic, AntibioticConsumptionStats, Patient, PatientEntries or importing bothLabRecordsandElectronicPharmacyStocks