Fix decode-uri-component DoS in frontend - #148
Merged
Merged
Conversation
Upgrade query-string and use-query-params to consume the fixed decode-uri-component 0.5.0 through a supported ESM dependency chain. Migrate imports and React Router integration while preserving existing query-string serialization behavior. This avoids forcing the ESM-only decoder into CommonJS query-string v7, which would leave an unsupported Node/tooling configuration.
bkammerd
approved these changes
Sep 30, 2026
artursarlo
added a commit
to pinterest/gprofiler-performance-studio
that referenced
this pull request
Oct 1, 2026
…aml, transitive deps) (#114) Backports frontend security fixes merged upstream (intel/gprofiler-performance-studio) after our last CVE sync (origin #88, which covered up to intel#132): - intel#148: fix decode-uri-component DoS. Upgrade query-string ^7 -> ^9.5.1 and use-query-params ^1.2.3 -> ^2.2.2 so the fixed decode-uri-component 0.5.0 is consumed through a supported ESM chain, and migrate imports / React Router integration (default queryString import + ReactRouter5Adapter). Pin decode-uri-component ^0.5.0 via resolutions. - intel#137: add resolutions for browserslist ^4.28.7, nanoid ^3.3.18, @humanfs/node ^0.16.8 (decode-uri-component pin superseded by intel#148's 0.5.0). - intel#139: js-yaml bumped to 4.3.2 via the existing ^4.3.0 resolution on lockfile regeneration. yarn.lock regenerated locally with Node 20 / Yarn 1.22.22; 'yarn build' passes. Divergent files (urls.js, ProfilesActions.jsx, AdhocProfilingView.jsx) had the query-string migration applied manually; the rest match upstream. nginx/mTLS divergence and the retained 'test' script are preserved as in #88. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade query-string and use-query-params to consume the fixed decode-uri-component 0.5.0 through a supported ESM dependency chain. Migrate imports and React Router integration while preserving existing query-string serialization behavior.
This avoids forcing the ESM-only decoder into CommonJS query-string v7, which would leave an unsupported Node/tooling configuration.
This is a variant of #141.