Conversation
Parameterize request and RQL filter values passed to ClickHouse instead of interpolating them into SQL strings. Allowlist dynamic query fields and use QueryContext for query execution. Fixes #152
Remove the trailing slash from the SVG download link to match the registered FastAPI endpoint. This avoids a 307 redirect that can downgrade HTTPS to HTTP behind a load balancer and cause browsers to block downloads. Verified downloads with development and minified production frontends. Fixes #44
Contributor
Author
|
Woops, I caught some unrelated commits. Deleting and re-pushing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flame graph download URL to match backend route
Remove the trailing slash from the SVG download link to match the
registered FastAPI endpoint. This avoids a 307 redirect that can downgrade
HTTPS to HTTP behind a load balancer and cause browsers to block downloads.
Verified downloads with development and minified production frontends.
Fixes #44