Skip to content

[VP] Fix VEBOX surface config crash in 60i->30p deinterlacing #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsukumijima wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

[VP] Fix VEBOX surface config crash in 60i->30p deinterlacing #1988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion media_softlet/agnostic/common/vp/hal/bufferMgr/vp_resource_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2561,7 +2561,11 @@ MOS_STATUS VpResourceManager::AssignVeboxResource(VP_EXECUTE_CAPS& caps, VP_SURF
if (caps.bDI || caps.bDiProcess2ndField)
{
bool b60fpsDi = resHint.b60fpsDi || caps.bDiProcess2ndField;
VEBOX_SURFACES_CONFIG cfg(b60fpsDi, caps.bSFC, m_sameSamples, m_outOfBound, m_currentFrameIds.pastFrameAvailable,
// sameSample path is only meaningful for 60fps DI workflows.
// For 30i->30p (single-field) DI, forcing sameSample can select an invalid
// VEBOX surface config combination.
const bool sameSamplesForConfig = b60fpsDi ? m_sameSamples : false;
VEBOX_SURFACES_CONFIG cfg(b60fpsDi, caps.bSFC, sameSamplesForConfig, m_outOfBound, m_currentFrameIds.pastFrameAvailable,
m_currentFrameIds.futureFrameAvailable, IsInterleaveFirstField(inputSurface->SampleType));
auto it = m_veboxSurfaceConfigMap.find(cfg.value);
if (m_veboxSurfaceConfigMap.end() == it)
Expand Down