[Build] Add missing <stdlib.h> include for atoi - #2027
Open
nuclearcat wants to merge 1 commit into
Open
Conversation
PFParser::getToken() calls atoi() but cm_printf_host.cpp includes only
project headers. The declaration has been arriving transitively through
the standard library headers those pull in.
libc++ has been removing such transitive includes release by release.
Under LLVM 22 with -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES=1 the path is
gone and the file no longer compiles:
cmrtlib/agnostic/share/cm_printf_host.cpp:226:43: error: use of
undeclared identifier 'atoi'
Include <stdlib.h> directly. The call site is unqualified atoi() rather
than std::atoi(), and <stdlib.h> is what the rest of the tree uses, so
it is preferred here over <cstdlib>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PFParser::getToken() calls atoi() but cm_printf_host.cpp includes only project headers. The declaration has been arriving transitively through the standard library headers those pull in.
libc++ has been removing such transitive includes release by release. Under LLVM 22 with -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES=1 the path is gone and the file no longer compiles:
cmrtlib/agnostic/share/cm_printf_host.cpp:226:43: error: use of
undeclared identifier 'atoi'
Include <stdlib.h> directly. The call site is unqualified atoi() rather than std::atoi(), and <stdlib.h> is what the rest of the tree uses, so it is preferred here over .
Sorry for PR message being much longer than patch.