chore: bump boxo to main, kad-dht v0.42.1 - #171
Merged
Merged
Conversation
Picks up the shorter /routing/v1 stale windows from ipfs/boxo#1195, so caches stop serving a two-day-old answer while someguy is healthy. go-libp2p-kad-dht v0.42.0 dropped the context argument from its constructors. Cancelling the context that built a DHT no longer stops it, so someguy lost its only shutdown path and had to grow an explicit one, the same way kubo closes both clients on stop. - drop ctx from dht.New, and from newBundledDHT which no longer used it - add bundledDHT.Close and call it on shutdown, covering the standard client too via io.Closer - update the Cache-Control assertions the new stale windows changed - restore the changelog section order broken in #169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the shorter
/routing/v1stale windows from ipfs/boxo#1195, so caches stop serving a two-day-old answer while someguy is healthy.max-ageis unchanged. The changelog has the new values.go-libp2p-kad-dht v0.42.0 dropped the context argument from its constructors, so cancelling the context that built a DHT no longer stops it. someguy relied on exactly that and had no
Close()at all, so it grew one, matching how kubo closes both clients on stop.ctxfromdht.New, and fromnewBundledDHTwhich no longer used itbundledDHT.Close, called on shutdown throughio.Closerso--dht=standardis covered tooCache-Controlassertions the new stale windows changedboxo is pinned to the current
mainHEAD (ipfs/boxo@1c8cf646367f) rather than the v0.42.0 tag, because ipfs/boxo#1195 landed after that release.Supersedes #168 and #166. The kad-dht bump alone breaks the build on the constructor change, so neither passes CI on its own.