VPP: Fix VLAN SVI LCP address sync and OSPF MTU - #3730
Open
jbemmel wants to merge 1 commit into
Open
Conversation
ipspace
added a commit
that referenced
this pull request
Aug 2, 2026
ipspace
approved these changes
Aug 2, 2026
ipspace
left a comment
ipspace
left a comment
Owner
There was a problem hiding this comment.
It works ;)) Thank you!
Will run complete integration tests for BIRD and VPP just to be on the safe side, but I don't expect any surprises.
ipspace
requested changes
Aug 2, 2026
ipspace
left a comment
ipspace
left a comment
Owner
There was a problem hiding this comment.
Ouch, we have a merge conflict, and I don't know enough about VPP to confidently resolve it. Please fix it, and I'll merge the PR.
ipspace
added
the
needs changes
jbemmel
marked this pull request as draft
August 2, 2026 13:11
BVI addresses were set before lcp create, so lcp-sync never mirrored them into the dataplane netns and BIRD/FRR had no SVI IPs. Also set Linux TAP MTU on SVIs (BVI packet MTU is not changeable) so OSPF DBD MTU matches peers, and run post-VPP setup once inside the netns. Co-authored-by: Cursor <cursoragent@cursor.com>
jbemmel
force-pushed
the
fix/vpp-vlan-svi-lcp-mtu
branch
from
August 2, 2026 13:16
236c20e to
001686c
Compare
jbemmel
marked this pull request as ready for review
August 2, 2026 13:17
Collaborator
Author
I restructured the startup script to run the whole thing inside the netns instead of every separate command - it looks more complicated than it is, and should be a one-time thing. Try now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BVI addresses were set before lcp create, so lcp-sync never mirrored them into the dataplane netns and BIRD/FRR had no SVI IPs. Also set Linux TAP MTU on SVIs (BVI packet MTU is not changeable) so OSPF DBD MTU matches peers, and run post-VPP setup once inside the netns.
Fixes #3724
Tested:
./device-module-test -d vpp -p clab initialandnetlab up ospf/ospfv2/06-vlan-mtu.yml -d vpp -p clab