Skip to content

Normalize line endings per .gitattributes - #3288

Closed
PopeyeTheSai10r wants to merge 2 commits into
masterfrom
chore/renormalize-eol-2026-09-24
Closed

PopeyeTheSai10r wants to merge 2 commits into
masterfrom
chore/renormalize-eol-2026-09-24

Conversation

@PopeyeTheSai10r

Copy link
Copy Markdown
Collaborator

Attempt to fix current issues with EOL.

Comment thread sites/sky.com/sky.com.test.js Dismissed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved issues were identified, and changes are limited to line-ending normalization.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@freearhey freearhey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still can't run or test the code from this repository, but the fact that the line endings change in the <site>/__data__ files as well could lead to an error in the future.

tohenk
tohenk previously approved these changes Sep 28, 2026

@tohenk tohenk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test on Windows pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants