Repository navigation
fix: make main compile and pass CI - #1
Merged
Merged
Conversation
…secrets, axum 0.8 route syntax)
- declare api::secrets and api::github_connector
- fix &RwLockReadGuard type mismatch in SecretStore::get
- replace missing urlencoding crate with a small percent_encode
- '/api/secrets/:path' panicked at router build under axum 0.8; use {path}
- add the new routes to ROUTE_TABLE (AF-116 test caught the omission)
- give every AppState test/example initializer a secrets store
- bump APP_VER and sw.js CACHE to 0.9.717 (checks.yml version guard)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MnV2XzAQTZHE8gsGMzGstC
…pi guard Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnV2XzAQTZHE8gsGMzGstC
…--doc) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnV2XzAQTZHE8gsGMzGstC
…e viewport The Secrets nav tab made the global menu 26px taller than an 800px window, so e2e tab-customizer.spec.ts saw it clipped by BODY. Cap its height. Bump APP_VER/CACHE to 0.9.718. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnV2XzAQTZHE8gsGMzGstC
ivomarino
marked this pull request as ready for review
September 30, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ivo · project thread
What & why
Main did not compile:
api::secretsandapi::github_connectorwere merged into the router without being declared,SecretStore::gethad a&RwLockReadGuardvs&Valuemismatch, andapp.jschanged without theAPP_VER/sw.jsbump the checks job requires. Fixing those exposed further breakage, fixed here too:github_connector.rsused theurlencodingcrate, which isn't a dependency; replaced with a smallpercent_encode./api/secrets/:pathis invalid in axum 0.8 and panics when the router is built; now/api/secrets/{path}.ROUTE_TABLE(caught by the AF-116 test).AppStateinitializer in tests and thesweep_serverexample needed the newsecretsfield; addedSecretStore::empty().APP_VERandsw.jsCACHEto 0.9.717.Checklist
cargo check --workspaceandcargo clippy --workspace --all-targets -- -D warningscleancargo test --workspace:cargo test -p amux-serverpasses except 6autofixtests, which fail in my sandbox because the disk-floor detector fires at 8.9 GB free (environmental)APP_VERandCACHE,node --checkpassesmainHow I tested
cargo check,cargo clippy -D warnings,cargo test -p amux-server.Known, left alone:
POST /api/secrets/{path}returns ok without persisting (existing TODO).🤖 Generated with Claude Code
https://claude.ai/code/session_01MnV2XzAQTZHE8gsGMzGstC
Generated by Claude Code