Skip to content

TCK tests for sorting based on expressions#1497

Open
njr-11 wants to merge 3 commits into
jakartaee:mainfrom
njr-11:tck-for-sortable-expressions
Open

TCK tests for sorting based on expressions#1497
njr-11 wants to merge 3 commits into
jakartaee:mainfrom
njr-11:tck-for-sortable-expressions

Conversation

@njr-11

@njr-11 njr-11 commented Jun 24, 2026

Copy link
Copy Markdown
Member

TCK tests for sorting based on expressions:

  • sorting based on a navigable expression that allows access to an attribute of an embeddable
  • sorting based on a single expression that performs an arithmetic computation involving two entity attributes
  • sorting based on multiple sort expressions

@njr-11 njr-11 added this to the 1.1 milestone Jun 24, 2026
@njr-11 njr-11 added the test Something test-related label Jun 24, 2026
@njr-11 njr-11 mentioned this pull request Jun 24, 2026
48 tasks
@Assertion(id = "829", strategy = """
Sort based on a navigable expression.
""")
public void testSortByNavigableExpression() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about use: shouldBe...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about use: shouldBe...

I'd rather not change just this one test. Hundreds of other tests in the TCK all start with test, including all of the other test methods within this class.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to rename tests from test* to shouldBe*, let's do that in a separate PR that can cover all occurrences.

@otaviojava

Copy link
Copy Markdown
Contributor

How about we move it in either as Nested classes?

@njr-11

njr-11 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

How about we move it in either as Nested classes?

I don't understand what your question means. Are you asking me to move the 3 new test methods that cover sorting by expressions into their own class, and you are suggesting that to be a nested class?

@njr-11

njr-11 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

I added commit e37b116 to move the new tests to a class of their own. Is that better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Something test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants