CRAN submission fixes - #27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Preview Deployment🚀 Preview URL: https://55907af5.mobdb.pages.dev Branch alias: https://fix-cran-fixes.mobdb.pages.dev |
Preview Deployment🚀 Preview URL: https://5c05fbaa.mobdb.pages.dev Branch alias: https://fix-cran-fixes.mobdb.pages.dev |
The San Francisco location filter example now matches 14 feeds and errored out during R CMD check, halting the rest of the example script. Wrap it in tryCatch since ambiguous multi-match is expected, documented behavior, not a bug to hide. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Preview Deployment🚀 Preview URL: https://f6c023c5.mobdb.pages.dev Branch alias: https://fix-cran-fixes.mobdb.pages.dev |
try() is the idiom recommended by the R Packages book for examples that may legitimately error (as dplyr::bind_cols() does) -- it shows the error to the reader instead of silently swallowing it, while still not halting execution of the rest of the example script. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Preview Deployment🚀 Preview URL: https://13d204cc.mobdb.pages.dev Branch alias: https://fix-cran-fixes.mobdb.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes items flagged in CRAN submission.