Minor changes on top of small_optimizations PR

src/rat_king_parser/config_parser/rat_config_parser.py

@@ -171,9 +171,8 @@ def _attempt_decryption(self, item_data: dict[str, Any]) -> dict[str, Any]:
                 logger.debug(f"Decryption failed with decryptor {decryptor} : {e}")
                 self._decryptor = None
 
-        if self._decryptor is None:
-            raise ConfigParserException("All decryptors failed")
-        return item_data
+        # If we exit the loop without returning, no decryptor succeeded
+        raise ConfigParserException("All decryptors failed")
 
     def _remap_config(
         self, decoded_config: dict[str, Any], config_fields_map: dict[int, str]

src/rat_king_parser/config_parser/utils/config_normalization.py

@@ -39,16 +39,23 @@
     "Group": ("Group", "Groub", "GroupTag", "TAG"),
 }
 
+# Strip underscores from aliases at build time so the lookup is consistent
+# with the underscore-stripped input key (e.g. so "mutex_string" actually
+# resolves to "Mutex")
 _normalized_keys_map = {
-    alias: k for k, aliases in normalized_keys.items() for alias in aliases
+    alias.replace("_", ""): k
+    for k, aliases in normalized_keys.items()
+    for alias in aliases
 }
 
 
 # Normalizes config keys/values for easier mapping
 def check_key_n_value(key: str, value: Any) -> tuple[str, Any]:
-    key_clean = key.replace("_", "")
-    if key_clean in _normalized_keys_map:
-        key = _normalized_keys_map[key_clean]
+    # Always strip underscores from the returned key to preserve the prior
+    # behavior of this function for unrecognized keys
+    key = key.replace("_", "")
+    if key in _normalized_keys_map:
+        key = _normalized_keys_map[key]
 
     if key in ("Hosts", "Ports") and isinstance(value, str):
         if value not in ("null", "false"):

src/rat_king_parser/config_parser/utils/decryptors/config_decryptor_aes_with_iv.py

@@ -111,7 +111,8 @@ def _derive_aes_passphrase_candidates(self, key_val: str) -> list[bytes]:
 
     # Decrypts encrypted config values with the provided cipher data
     def decrypt_encrypted_strings(
-        self, encrypted_strings: dict[str, str]) -> dict[str, str]:
+        self, encrypted_strings: dict[str, str]
+    ) -> dict[str, str]:
         logger.debug("Decrypting encrypted strings...")
         if self._key_candidates is None:
             self._key_candidates = self._get_aes_key_candidates(encrypted_strings)
@@ -193,7 +194,8 @@ def decrypt_encrypted_strings(
 
     # Extracts AES key candidates from the payload
     def _get_aes_key_candidates(
-        self, encrypted_strings: dict[str, str]) -> list[bytes]:
+        self, encrypted_strings: dict[str, str]
+    ) -> list[bytes]:
         logger.debug("Extracting AES key candidates...")
         keys = []
 
@@ -284,7 +286,9 @@ def _get_aes_metadata(self) -> None:
         if not self._metadata_candidates:
             raise ConfigParserException("Could not identify AES metadata")
 
-        # Extraction of common metadata
+        # Key size, block size, and algo are properties of the embedded AES
+        # class definition, not of any single salt/iter candidate, so they are
+        # extracted once and shared across all metadata candidates
         self._key_size, self._block_size, self._aes_algo = (
             self._get_aes_key_and_block_size_and_algo()
         )