Updated doc for default connection mode - #7011
Conversation
probot-autolabeler
Bot
added
the
documentation
kmartens27
left a comment
kmartens27
left a comment
There was a problem hiding this comment.
everything looks okay to me from a docs persepctive, thanks very much @Harishrao13.
In the future, make sure that you are submitting pull requests from a new branch in your forked repo. The Jenkins contributing guide outlines the proper steps to take when creating pull requests to Jenkins.io, which includes creating a new branch for any work you want to perform. This also avoids updating the master branch, which can cause issues if it is not aligned with the upstream repository.
| The advantage is that a more standard transport is used, | ||
| avoiding problems with many reverse proxies or the need for special proxy configuration. |
There was a problem hiding this comment.
| The advantage is that a more standard transport is used, | |
| avoiding problems with many reverse proxies or the need for special proxy configuration. | |
| The advantage is that a more standard transport is used, avoiding problems with many reverse proxies or the need for special proxy configuration. |
Suggestion to combine lines for full sentence
| ==== HTTP connection mode | ||
|
|
||
| This is the default mode, though you may pass the `-http` option explicitly for clarity. | ||
| Starting from Jenkins 2.391, the default mode is `-webSocket`. To use the HTTP mode, you must explicitly pass the `-http` option. |
There was a problem hiding this comment.
| Starting from Jenkins 2.391, the default mode is `-webSocket`. To use the HTTP mode, you must explicitly pass the `-http` option. | |
| Starting from Jenkins 2.391, the default mode is `-webSocket`. | |
| To use the HTTP mode, you must explicitly pass the `-http` option. |
Separating out full sentences
|
Sorry, I will follow the guidelines next time |
|
@Harishrao13 no worries at all! I hope this is more educational than anything else. I just wanted to point this out so that you have an easier, and hopefully headache-free experience going forward. Since the "master" or "main" branch should be the absolute truth of the repository, it is best practice to use a branch to perform any changes or work. This keeps the original information in tact, without threat of anything being changed or lost inadvertently. |
3 participants
Closes #6986