Skip to content

Add websocket-jetty11 permissions for prototyping - #2699

Merged
timja merged 1 commit into
jenkins-infra:masterfrom
basil:jetty11
Aug 2, 2022
Merged

Add websocket-jetty11 permissions for prototyping#2699
timja merged 1 commit into
jenkins-infra:masterfrom
basil:jetty11

Conversation

@basil

@basil basil commented Aug 2, 2022

Copy link
Copy Markdown
Contributor

Description

Like #2638, but for Jetty 11. Even though we're not using Jetty 11 yet, the lack of these permissions prevents me from getting an incremental build of jenkinsci/jenkins#6085:

Invalid archive retrieved from Jenkins, perhaps the plugin is not properly incrementalized?
Error: ZIP error: Error: No permissions for org/jenkins-ci/main/websocket-jetty11/2.363-rc32712.2307a_6dc9273/websocket-jetty11-2.363-rc32712.2307a_6dc9273-sources.jar from https://ci.jenkins.io/job/Core/job/jenkins/job/PR-6085/3/artifact/**/*2307a*6dc9273*/*2307a*6dc9273*/*zip*/archive.zip

The lack of that incremental build prevents me from bootstrapping the test harness and doing further prototyping, so I would like to get these permissions set up.

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@basil
basil requested a review from a team as a code owner August 2, 2022 19:52
@timja
timja enabled auto-merge (squash) August 2, 2022 19:58
@timja
timja merged commit 96f4f06 into jenkins-infra:master Aug 2, 2022
@basil

basil commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

Thank you very much!

@basil
basil deleted the jetty11 branch August 2, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants