Add support for ECS agent pools to avoid cold start - #400
Open
arechavarria wants to merge 3 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return FormValidation.ok(); | ||
| } | ||
|
|
||
| public FormValidation doCheckMinIdleAgents(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| return FormValidation.ok(); | ||
| } | ||
|
|
||
| public FormValidation doCheckMinIdleAgents(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
| return FormValidation.error("Must be a non-negative integer"); | ||
| } | ||
|
|
||
| public FormValidation doCheckMaxIdleMinutes(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| return FormValidation.error("Must be a non-negative integer"); | ||
| } | ||
|
|
||
| public FormValidation doCheckMaxIdleMinutes(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
| return FormValidation.error("Must be a non-negative integer"); | ||
| } | ||
|
|
||
| public FormValidation doCheckMaintainSchedule(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing POST/RequirePOST annotation
| return FormValidation.error("Must be a non-negative integer"); | ||
| } | ||
|
|
||
| public FormValidation doCheckMaintainSchedule(@QueryParameter String value) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces the functionality to maintain a pool of pre-warmed ECS agents. This allows Jenkins to execute tasks more quickly by avoiding the delay caused when containers are started from scratch.
To achieve this, the classes ECSAgentPool and ECSAgentPoolMaintainer were added, along with adjustments to ECSCloud, ECSPoolSlave, and other related components.
Testing done
The new functionality was manually verified by running Jenkins with a configured agent pool. It was observed that the preexisting agents are used correctly and maintained according to the configuration.
Submitter checklist
Tests: