Migrate from Commons Lang 2 to Commons Lang 3 - #434
Open
timja-bot wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from deprecated/EOL Commons Lang 2 to Commons Lang 3.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
org.apache.commons.lang.*imports toorg.apache.commons.lang3.*across 11 filesand declared
io.jenkins.plugins:commons-lang3-api.ObjectUtils.equals(removed in Lang 3) becomesObjects.equalsat the two call sites inECSService.6.2211.v27f680c93c53so theban-commons-lang-2enforcer rule isavailable, and enabled it.
ECSService.registerTemplatedoes:template.getTags()is aList<ECSTaskTemplate.Tag>whiletagsis aList<com.amazonaws.services.ecs.model.Tag>.Two lists of unrelated element types are never equal unless both are empty, so
templateTagsMatchesExistingTagsis effectively alwaysfalsewhenever tags are configured — andthe task definition gets re-registered on every provision.
This is not new:
ObjectUtils.equals(Object, Object)had the same behaviour, it just hid the typemismatch from SpotBugs, which flags it as
EC_UNRELATED_TYPESonce the call becomesObjects.equals.I have deliberately not changed the behaviour here — I added a
@SuppressFBWarningswith thatjustification so this PR stays a pure migration. Worth a follow-up to compare the tags properly.
Testing done
mvn -B -ntp clean verifypasses locally on Java 21 / macOS.The
ban-commons-lang-2enforcer rule is enabled in this PR, so the build fails if anorg.apache.commons.lang.*import comes back.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.