Skip to content

fix jcasc test harness - #133

Merged
jvz merged 2 commits into
jenkinsci:masterfrom
jetersen:fix/jcasc-test-harness
Jan 14, 2020
Merged

fix jcasc test harness#133
jvz merged 2 commits into
jenkinsci:masterfrom
jetersen:fix/jcasc-test-harness

Conversation

@jetersen

Copy link
Copy Markdown
Member

No description provided.

@jglick jglick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(once merged with a fixed subsumed PR)

@jglick

jglick commented Jan 14, 2020

Copy link
Copy Markdown
Member

needs merge

@jglick
jglick requested a review from jvz January 14, 2020 15:31
@jvz

jvz commented Jan 14, 2020

Copy link
Copy Markdown
Member

Is this waiting on anything else before merging?

@jetersen

Copy link
Copy Markdown
Member Author

there @jvz hopefully once it is green, we are good to go :D

@jvz

jvz commented Jan 14, 2020

Copy link
Copy Markdown
Member

Got a strange test failure that may or may not be relevant.

@jetersen

Copy link
Copy Markdown
Member Author

unrelated it also happened on the other PR

@jetersen jetersen closed this Jan 14, 2020
@jetersen jetersen reopened this Jan 14, 2020
@jvz
jvz merged commit 4e20d62 into jenkinsci:master Jan 14, 2020
@jvz

jvz commented Jan 14, 2020

Copy link
Copy Markdown
Member

Thanks for the PR!

@jglick

jglick commented Jan 14, 2020

Copy link
Copy Markdown
Member

@jvz note that we are going to need a release of this: jenkinsci/bom#164 (comment)

@jvz

jvz commented Jan 14, 2020

Copy link
Copy Markdown
Member

Making one right now.

@jvz

jvz commented Jan 14, 2020

Copy link
Copy Markdown
Member

Released as 2.3.1.

@jetersen
jetersen deleted the fix/jcasc-test-harness branch January 15, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants