[JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true by jglick · Pull Request #130 · jenkinsci/docker-inbound-agent

jglick · 2019-12-10T02:04:02Z

See JEP-222. Alternative to #129. Works with jenkinsci/remoting#357. Requires #147.

slide · 2019-12-21T23:15:51Z

We will need to update the Windows side as well (https://github.com/jenkinsci/docker-jnlp-slave/blob/master/jenkins-agent.ps1)

jglick · 2019-12-22T00:19:38Z

Yes, I did not try that yet but I could.

olblak

Lgtm

oleg-nenashev

Please also update README

…websocket

oleg-nenashev

Looks good to me, but the upstream pull request in Remoting needs to be released first

jglick · 2020-01-04T14:19:34Z

the upstream pull request in Remoting needs to be released first

Yes, this is on hold until the core changes are released.

…websocket

oleg-nenashev

https://github.com/jenkinsci/remoting/releases/tag/remoting-4.0 must be integrated and released in the parent image: https://github.com/jenkinsci/docker-slave . Otherwise this feature will not work

jglick · 2020-01-27T18:56:58Z

[Remoting 4.0] must be integrated and released in the parent image

Sure. I presume someone like @jeffret-b would be doing this as a routine task.

jeffret-b · 2020-01-27T18:58:43Z

I was hoping to get to that today, but may have more pressing tasks.

jglick · 2020-01-27T19:05:12Z

I think there is no rush. This change is needed for people who wish to use WebSocket transport for agents managed by the kubernetes plugin’s cloud, which is not the typical use case. Otherwise you could just rely on the *.jnlp parsing to set -webSocket (see jenkinsci/docker-agents#693). I suppose there are other people using this launcher script for Dockerized inbound agents who could benefit. And of course it only matters if you are running 2.217+.

jeffret-b · 2020-01-27T19:23:14Z

I managed to squeeze it in before lunch. The PRs are up.

jglick · 2020-02-12T13:25:26Z

So can you merge & release this @jeffret-b, or whoever is maintaining this repo?

jeffret-b · 2020-02-12T18:41:28Z

I don't have permission in this repository. Maybe @slide or @oleg-nenashev

jglick · 2020-02-12T20:27:09Z

@MarkEWaite thanks! Now can you can a release please? 3.40-1...master

MarkEWaite · 2020-02-12T21:07:31Z

I would like to leave this for @oleg-nenashev to release, since he's released the most recent several versions of it and I've never released a version. If @oleg-nenashev has not been able to release it by tomorrow, I'll attempt the release.

jglick · 2020-02-17T16:05:50Z

ping @MarkEWaite @oleg-nenashev

MarkEWaite · 2020-02-18T02:17:06Z

Sorry that I missed this one @jglick. As I look at the repository, the release process is not immediately clear to me. I'll talk with @oleg-nenashev tomorrow and learn how to release from this repository.

jglick · 2020-02-18T02:18:16Z

I am not sure either. It may suffice to just create a tag and wait for Docker Hub automated builds to kick in.

jglick · 2020-02-18T02:21:10Z

IIUC from the Jenkinsfile, Linux publishing is passive, whereas a Jenkins project publishes the Windows version.

slide · 2020-02-18T16:00:23Z

The linux publishing should be done on dockerhub builds, though I am not sure how the tagging for specific versions takes place. For the Windows versions, we are publishing them via trusted.ci, we do not currently do a version specific release, I would need to look into that.

oleg-nenashev · 2020-02-19T14:35:11Z

on it

MarkEWaite · 2020-02-20T19:17:08Z

The 4.0.1-1 release is now available and ready to use. A CONTRIBUTING document has also been added which includes a video link to a session that describes the release process.

jglick · 2020-02-20T19:34:50Z

$ docker run --rm jenkinsci/jnlp-slave:4.0.1-1 2>&1 | fgrep -i websocket
 -webSocket                            : Make a WebSocket connection to Jenkins

🎉

Fix issue with paths when using MinGit busybox

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

…socket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

JENKINS_WEB_SOCKET=true

eebbdf2

This was referenced Dec 10, 2019

[JEP-222] Pass JENKINS_WEB_SOCKET when so configured jenkinsci/kubernetes-plugin#661

Merged

Amendments to JEP-222 jenkinsci/jep#251

Merged

jglick marked this pull request as ready for review December 21, 2019 03:48

jglick requested a review from a team as a code owner December 21, 2019 03:48

slide approved these changes Dec 21, 2019

View reviewed changes

olblak approved these changes Dec 22, 2019

View reviewed changes

oleg-nenashev suggested changes Dec 23, 2019

View reviewed changes

oleg-nenashev mentioned this pull request Dec 25, 2019

Add JEP link resolution to Release Drafter jenkinsci/.github#28

Merged

jglick added 2 commits January 3, 2020 17:17

Noting new variable in documentation.

ccda58f

Merge branch 'master' of github.com:jenkinsci/docker-jnlp-slave into …

eb42877

…websocket

jglick requested a review from oleg-nenashev January 3, 2020 22:17

oleg-nenashev added the enhancement label Jan 3, 2020

oleg-nenashev changed the title ~~[JEP-222] JENKINS_WEB_SOCKET=true~~ [JEP-222] - Allow enabling the websokect mode by passing the JENKINS_WEB_SOCKET=true environment variable Jan 3, 2020

oleg-nenashev approved these changes Jan 3, 2020

View reviewed changes

jglick changed the title ~~[JEP-222] - Allow enabling the websokect mode by passing the JENKINS_WEB_SOCKET=true environment variable~~ [JEP-222] - Allow WebSocket mode to be enabled by passing the JENKINS_WEB_SOCKET=true environment variable Jan 4, 2020

jglick added 2 commits January 27, 2020 11:23

Merge branch 'master' of github.com:jenkinsci/docker-jnlp-slave into …

8318da4

…websocket

Script seems to be using tabs not spaces

2daa17d

jglick changed the title ~~[JEP-222] - Allow WebSocket mode to be enabled by passing the JENKINS_WEB_SOCKET=true environment variable~~ [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true Jan 27, 2020

Also patch the PowerShell script

4d68e84

jglick commented Jan 27, 2020

View reviewed changes

Comment thread jenkins-agent.ps1 Outdated

-eq rather than .Equals

8164339

slide approved these changes Jan 27, 2020

View reviewed changes

oleg-nenashev suggested changes Jan 27, 2020

View reviewed changes

jglick requested review from jeffret-b and oleg-nenashev February 11, 2020 19:13

jeffret-b approved these changes Feb 11, 2020

View reviewed changes

MarkEWaite merged commit 6b9b5c1 into jenkinsci:master Feb 12, 2020

jglick deleted the websocket branch February 12, 2020 20:25

jglick added a commit to jglick/kubernetes-plugin that referenced this pull request Feb 20, 2020

Pick up jenkinsci/docker-inbound-agent#130

f21934c

lemeurherve pushed a commit to lemeurherve/jenkinsci-docker-inbound-agent that referenced this pull request Nov 19, 2023

Merge pull request jenkinsci#130 from slide/windows-git-fix

f64d5b6

Fix issue with paths when using MinGit busybox

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

dafaa9b

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

4f46bbc

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

895f74e

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

357b50f

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

939a665

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

4ff0d9a

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

0e98646

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

6e27e1d

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 28, 2023

[PATCH] Merge pull request jenkinsci/docker-inbound-agent#130 from jg…

680636c

…lick/websocket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 12, 2024

Merge pull request jenkinsci/docker-inbound-agent#130 from jglick/web…

fdf9ed8

…socket [JEP-222] Enable WebSocket mode by passing JENKINS_WEB_SOCKET=true

Uh oh!

Uh oh!

Conversation

jglick commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

slide commented Dec 21, 2019

Uh oh!

jglick commented Dec 22, 2019

Uh oh!

olblak left a comment

Choose a reason for hiding this comment

Uh oh!

oleg-nenashev left a comment

Choose a reason for hiding this comment

Uh oh!

oleg-nenashev left a comment

Choose a reason for hiding this comment

Uh oh!

jglick commented Jan 4, 2020

Uh oh!

Uh oh!

oleg-nenashev left a comment

Choose a reason for hiding this comment

Uh oh!

jglick commented Jan 27, 2020

Uh oh!

jeffret-b commented Jan 27, 2020

Uh oh!

jglick commented Jan 27, 2020

Uh oh!

jeffret-b commented Jan 27, 2020

Uh oh!

jglick commented Feb 12, 2020

Uh oh!

jeffret-b commented Feb 12, 2020

Uh oh!

jglick commented Feb 12, 2020

Uh oh!

MarkEWaite commented Feb 12, 2020

Uh oh!

jglick commented Feb 17, 2020

Uh oh!

MarkEWaite commented Feb 18, 2020

Uh oh!

jglick commented Feb 18, 2020

Uh oh!

jglick commented Feb 18, 2020

Uh oh!

slide commented Feb 18, 2020

Uh oh!

oleg-nenashev commented Feb 19, 2020

Uh oh!

MarkEWaite commented Feb 20, 2020

Uh oh!

jglick commented Feb 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jglick commented Dec 10, 2019 •

edited

Loading