Skip to content

Exclusion is no longer needed - #500

Merged
jglick merged 1 commit into
jenkinsci:masterfrom
Vlatombe:cleanup-JENKINS-36779
Oct 13, 2022
Merged

Exclusion is no longer needed#500
jglick merged 1 commit into
jenkinsci:masterfrom
Vlatombe:cleanup-JENKINS-36779

Conversation

@Vlatombe

Copy link
Copy Markdown
Member

Fixes

[2022-10-13T07:50:05.173Z] [WARNING] 'build.plugins.plugin.(groupId:artifactId)' must be unique but found duplicate declaration of plugin org.apache.maven.plugins:maven-enforcer-plugin @ org.jenkins-ci.main:jenkins-test-harness:${changelist}, /home/jenkins/workspace/Core_jenkins-test-harness_PR-499/pom.xml, line 290, column 15

Stapler actually pulls guava 11.0.1 so there doesn't seem to be an upperboundcheck problem.
jenkinsci/stapler#123

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe added the chore label Oct 13, 2022
Comment thread pom.xml
Comment on lines -294 to -295
excluding Guava from the RequireUpperBoundDeps check. The long-term fix is
tracked in JENKINS-36779.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.jenkins.io/browse/JENKINS-36779 closed in 2.320. For now

<jenkins.version>2.249</jenkins.version>
but we will probably need to move to 2.361.x at some point (#453).

@jglick
jglick merged commit 72bab69 into jenkinsci:master Oct 13, 2022
@Vlatombe
Vlatombe deleted the cleanup-JENKINS-36779 branch October 13, 2022 11:47
@basil

basil commented Oct 13, 2022

Copy link
Copy Markdown
Member

Still needed so long as the test harness still supports Jenkins versions prior to 2.320 as far as I can tell.

@jglick

jglick commented Oct 13, 2022

Copy link
Copy Markdown
Member

🤔 how could that be? CI passes and this is just removing plugin configuration for this project, which should not affect the flattened form or at least not be relevant for projects consuming this as a dependency?

@basil

basil commented Oct 13, 2022

Copy link
Copy Markdown
Member

which should not affect the flattened form

You are right, I was thinking about plugin-pom instead. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants