Exclusion is no longer needed - #500
Merged
Merged
Conversation
jglick
approved these changes
Oct 13, 2022
Comment on lines
-294
to
-295
| excluding Guava from the RequireUpperBoundDeps check. The long-term fix is | ||
| tracked in JENKINS-36779. |
Member
There was a problem hiding this comment.
https://issues.jenkins.io/browse/JENKINS-36779 closed in 2.320. For now
Line 59 in e5ab6d2
Member
|
Still needed so long as the test harness still supports Jenkins versions prior to 2.320 as far as I can tell. |
Member
|
🤔 how could that be? CI passes and this is just removing plugin configuration for this project, which should not affect the flattened form or at least not be relevant for projects consuming this as a dependency? |
Member
You are right, I was thinking about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Stapler actually pulls guava 11.0.1 so there doesn't seem to be an upperboundcheck problem.
jenkinsci/stapler#123