Exposing basics of ResourceDomainConfiguration via Java API - #4335
Merged
jglick merged 2 commits intoNov 1, 2019
Conversation
jglick
commented
Oct 31, 2019
daniel-beck
reviewed
Oct 31, 2019
daniel-beck
left a comment
daniel-beck
left a comment
Member
There was a problem hiding this comment.
Would it make sense to mark this as @Beta or some similar indicator that consumers should not rely on API stability?
Member
Author
Good idea, I will do that. |
daniel-beck
approved these changes
Oct 31, 2019
res0nance
approved these changes
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amends #4239. I needed to get and set the URL here from Java code, but ran into a compilation error. Note that these methods are already effectively publicized via reflection in JCasC.
(Note that my real goal is simply to define the URL, or the host portion of the URL, via system property, without a
configuration-as-codedependency or the like. Making these Java calls via@Initializeris just one way to accomplish that.)Proposed changelog entries
ResourceDomainConfigurationaccessible from plugins.