Adapt to newer HtmlUnit - #4398
Merged
Merged
Conversation
WebClient.addRequestHeader will no longer override a header in a WebRequest, such as when the same WebClient/WebRequest was previously used with different headers.
…characters. HtmlUnit/htmlunit@2c49568 picks up apache/httpcomponents-client@8c04c6a which is the actual change.
jglick
referenced
this pull request
in apache/httpcomponents-client
Dec 18, 2019
…ashes in path component
oleg-nenashev
approved these changes
Dec 18, 2019
jglick
marked this pull request as ready for review
December 18, 2019 13:56
timja
approved these changes
Dec 18, 2019
oleg-nenashev
added
internal
ready-for-merge
Member
|
I plan to merge it tomorrow if no negative feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkinsci/jenkins-test-harness#171 seems to have introduced some test regression. I could not find anything about redirects in the library diff but anyway I think this test from #4239 was meant to test
doIndex, which requires a trailing slash.Will start by verifying that there are no further failures with the trunk library, then either revert the POM or release the library.