Skip to content

[JENKINS-70103] WeakHashMap broken for looking up Jetty Session in WebSocket response - #7412

Merged
basil merged 4 commits into
jenkinsci:masterfrom
jglick:providerSession-JENKINS-70103
Nov 20, 2022
Merged

[JENKINS-70103] WeakHashMap broken for looking up Jetty Session in WebSocket response#7412
basil merged 4 commits into
jenkinsci:masterfrom
jglick:providerSession-JENKINS-70103

Conversation

@jglick

@jglick jglick commented Nov 18, 2022

Copy link
Copy Markdown
Member

See JENKINS-70103. Amends #6780. Supersedes #7406.

Testing done

Used JNLPLauncherRealTest.

Proposed changelog entries

  • Memory leak when repeatedly connecting WebSocket agents.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jglick
jglick requested review from Vlatombe, amuniz and basil November 18, 2022 19:47
@NotMyFault NotMyFault added the bug For changelog: Minor bug. Will be listed after features label Nov 19, 2022
Comment thread core/src/main/java/jenkins/websocket/WebSockets.java Outdated
Comment thread websocket/spi/src/main/java/jenkins/websocket/Provider.java Outdated
@basil
basil requested a review from a team November 19, 2022 19:28
@timja

timja commented Nov 19, 2022

Copy link
Copy Markdown
Member

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 19, 2022
@basil
basil merged commit aedacba into jenkinsci:master Nov 20, 2022
@jglick
jglick deleted the providerSession-JENKINS-70103 branch November 21, 2022 11:59
krisstern pushed a commit to krisstern/jenkins that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants