Stop shipping metainf-services in the WAR - #8174
Merged
Merged
Conversation
basil
commented
Jun 20, 2023
| <dependency> | ||
| <groupId>org.kohsuke.metainf-services</groupId> | ||
| <artifactId>metainf-services</artifactId> | ||
| <optional>true</optional> |
NotMyFault
approved these changes
Jun 21, 2023
MarkEWaite
approved these changes
Jun 21, 2023
timja
approved these changes
Jun 21, 2023
Contributor
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
yaroslavafenkin
pushed a commit
to yaroslavafenkin/jenkins
that referenced
this pull request
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6780 (comment) I had noticed that we started shipping this JAR in the WAR file and expressed some discomfort about it, implying the question: "is this really necessary?" to which I did not receive a reply. After thinking about it some more recently, I have concluded that it is not only unnecessary but also undesirable, for the following reasons:
core/pom.xmlwhich marks thisoptionalso that it is excluded (undone bywebsocket/jetty10/pom.xml)metainf-servicesrather than relying on core's copyI did a search of both open-source and proprietary plugins and could not find one that was relying on core's copy rather than its own. In other words, plugins were directly declaring their dependency on this library before core started bundling it, and none of them have dropped that dependency in favor of core's copy.
If someone felt strongly about managing this via core and wanted to update all plugins to consume core's copy rather than their own, and make
core/pom.xmlconsistent withwebsocket/jetty10/pom.xml, I would not oppose that. This PR is the exact opposite: makingwebsocket/jetty10/pom.xmlconsistent withcore/pom.xmland the status quo in plugins by removingmetainf-servicesfrom the WAR file (in other words, restoring the status quo as it was prior to #6780).Testing done
Built the WAR and ensured that the services files were generated as before but that we were no longer shipping the
metainf-servicesJAR in the WAR file.Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge: