JEP draft: WebSocket Services - #250
Conversation
rtyler
left a comment
rtyler
left a comment
There was a problem hiding this comment.
From my perspective this a well structured JEP, great work @jglick! I would like one other person to weigh in, but if they do not before the beginning of December, I'll go ahead and number this (assuming no specific range requested), .
omehegan
left a comment
omehegan
left a comment
There was a problem hiding this comment.
From the perspective of a casual reader, this is excellent. It's thorough and easy to understand, and I'm not left with any questions about the proposal. Well done!
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Looks good from the structure perspective. +1 for accepting it as a JEP draft
jeffret-b
left a comment
jeffret-b
left a comment
There was a problem hiding this comment.
This is great. It explains things well and provides useful information. The approach makes a lot of sense. I like how it fits into the existing infrastructure. This will be a great addition to the existing infrastructure mechanisms.
I haven't yet looked at the implementation PRs, but I'll glance over them now and plan on more thorough reviews later.
|
@rtyler I guess this can be merged & numbered now? |
|
I might get to merging it next week after DWJW
…On Mon, Dec 2, 2019, 18:10 Jesse Glick ***@***.***> wrote:
@rtyler <https://github.com/rtyler> I guess this can be merged & numbered
now?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#250?email_source=notifications&email_token=AAW4RIDXAXABBZWATDHBT2DQWVFP3A5CNFSM4JQWBZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUL7IA#issuecomment-560512928>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RICR3HDENEL4CPSJF23QWVFP3ANCNFSM4JQWBZHA>
.
|
…ck to zeeëend) Co-Authored-By: Jeff Thompson <37345299+jeffret-b@users.noreply.github.com>
|
@oleg-nenashev No reason to wait. |
|
No reason, just a bandwidth issue
…On Wed, Dec 4, 2019, 09:56 Liam Newman ***@***.***> wrote:
Merged #250 <#250> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#250?email_source=notifications&email_token=AAW4RIHU5HHD4KTGUX2SZETQW55E3A5CNFSM4JQWBZHKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVIJHJUA#event-2853336272>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIGYD5I5GVQA6UWYXGLQW55E3ANCNFSM4JQWBZHA>
.
|
8 participants
Prototype implementation in jenkinsci/jenkins#4369 and its upstreams.