Skip to content

Add property for detection of inline javascript #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mawinter69 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add property for detection of inline javascript #814

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e8e79e
Add property for detection of inline javascript
mawinter69 Nov 16, 2025
028f396
rename variable
mawinter69 Nov 16, 2025
f478bbe
Merge branch 'master' into inline-js-checks
mawinter69 Dec 30, 2025
cca69b0
spotless
mawinter69 Dec 30, 2025
e4ab8bb
pass parameter
mawinter69 Dec 30, 2025
01742c6
Merge branch 'master' into inline-js-checks
mawinter69 Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/java/org/jenkinsci/maven/plugins/hpi/TestInsertionMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ public class TestInsertionMojo extends AbstractJenkinsMojo {
@Parameter(property = "jelly.requirePI", defaultValue = "true")
private boolean requirePI;

/**
* If true, verify that all the jelly scripts don't contain inline javascript.
*/
@Parameter(property = "jelly.prohibitInlineJS", defaultValue = "true")
private boolean prohibitInlineJS;

/**
* Optional string that represents "groupId:artifactId" of the Jenkins test harness.
* If left unspecified, the default groupId/artifactId pair for the Jenkins test harness is looked for.
Expand Down Expand Up @@ -138,7 +144,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
class %s extends org.jvnet.hudson.test.injected.InjectedTestBase {

%s() {
super("%s", "%s", "%s", "%s", %b);
super("%s", "%s", "%s", "%s", %b, %b);
}
}
""".formatted(
Expand All @@ -149,12 +155,12 @@ class %s extends org.jvnet.hudson.test.injected.InjectedTestBase {
project.getArtifactId(),
project.getVersion(),
escape(project.getBuild().getOutputDirectory()),
requirePI);
requirePI,
prohibitInlineJS);
Files.writeString(javaFile.toPath(), content);
} catch (IOException e) {
throw new MojoExecutionException("Failed to create injected tests", e);
}

project.addTestCompileSourceRoot(f.getAbsolutePath());

try {
Expand Down