Skip to content

Bump jcasc version - #173

Merged
kuisathaverat merged 1 commit into
jenkinsci:masterfrom
timja:bump-jcasc
Jan 19, 2020
Merged

Bump jcasc version#173
kuisathaverat merged 1 commit into
jenkinsci:masterfrom
timja:bump-jcasc

Conversation

@timja

@timja timja commented Jan 14, 2020

Copy link
Copy Markdown
Member

JCasc had to create a new dependency that wasn't a tests classifier because maven doesn't allow you to bring dependencies through classifiers.

Upgrading here so that PCT works again,

Tracking:
jenkinsci/bom#164

@timja

timja commented Jan 17, 2020

Copy link
Copy Markdown
Member Author

🚢 @oleg-nenashev ?

@kuisathaverat
kuisathaverat merged commit 6edaff1 into jenkinsci:master Jan 19, 2020
@timja

timja commented Jan 19, 2020

Copy link
Copy Markdown
Member Author

@kuisathaverat any chance of backporting this to pre 2.190.x bump? Otherwise we won’t be able to bump Jcasc in the bom on any of the pre-2.190.x lines

kuisathaverat pushed a commit to kuisathaverat/ssh-agents-plugin that referenced this pull request Jan 19, 2020
@kuisathaverat

kuisathaverat commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

@timja
on the master is not possible because of JENKINS-59728, but we have a 1.30.x branch for versions before 2.190.1, I backport only for critical fixes, and in 3 months it will be abandoned. However, I've backported this fix in #175 in case that a version of that branch can help you with the BOM, if not, I do not see another way.

@timja

timja commented Jan 19, 2020

Copy link
Copy Markdown
Member Author

@timja
on the master is not possible because of JENKINS-59728, but we have a 1.30.x branch for versions before 2.190.1, I backport only for critical fixes, and in 3 months it will be abandoned. However, I've backported this fix in #175 in case that a version of that branch can help you with the BOM, if not, I do not see another way.

Thanks for the backport, we'll need a release for it to work (PCT needs a tag, at least in its current setup on the bom).

Yes makes sense to abandon it after a few months.

I'm trying to get the 2.190.x bom line fixed and shipped currently, (trilead-api issues across a few plugins is what's preventing it atm).

@timja
timja deleted the bump-jcasc branch January 19, 2020 21:42
@kuisathaverat

kuisathaverat commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

I just released ssh-slaves-1.30.4

kuisathaverat added a commit that referenced this pull request Jan 23, 2020
Co-authored-by: Tim Jacomb <t.jacomb@kainos.com>
@timja

timja commented Jan 23, 2020

Copy link
Copy Markdown
Member Author

I just released ssh-slaves-1.30.4

Thanks! bumped it in the bom PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants