Implement a cache in AbstractTearOff even when MetaClass.NO_CACHE is set - #184
Merged
Merged
Conversation
jglick
force-pushed
the
AbstractTearOff-cache
branch
from
April 30, 2020 19:11
94841fd to
1555fd1
Compare
jglick
marked this pull request as ready for review
April 30, 2020 19:11
Member
Author
jeffret-b
approved these changes
Jun 10, 2020
jeffret-b
left a comment
jeffret-b
left a comment
Contributor
There was a problem hiding this comment.
Looks good. It should perform handy caching for those development situations, to speed things up nicely.
It's a reasonable adjustment to the NO_CACHE behavior. It still meets the necessary behavior of that flag, but provides a simple, but helpful cache to speed things up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements my proposal from jenkinsci/maven-hpi-plugin#40 (comment). Jenkins in development mode—
hpi:run,jetty:run,surefire:test—setsMetaClass.NO_CACHEflag. (Usually via the system propertystapler.jelly.noCache, though in fact it affects Groovy views too.) This flag ensures that changes to source files are applied on every new page load, which is good, but also forces every*.jellyor*.groovyfile to be reparsed whenever accessed—in some cases multiple times in a single HTTP response! That adds a lot of CPU overhead and contributes to page loads being noticeably slower than in production.This patch retains most of the
NO_CACHEbehavior (it is interpreted in a number of places), but caches parsed/compiled views if they have not actually been changed on disk. There is still a bit of overhead to check file timestamps but things feel quite a bit snappier duringhpi:run, especially on a form-heavy page like/configure.