[JENKINS-60866] Make st:bind tag and JavaScript proxy work without inline JS - #385
Merged
Conversation
12 tasks
daniel-beck
changed the title
daniel-beck
commented
Jul 21, 2022
daniel-beck
commented
Jul 21, 2022
jglick
reviewed
Jul 25, 2022
jglick
left a comment
jglick
left a comment
Member
There was a problem hiding this comment.
Do not recall well enough how st:bind works to offer a meaningful review
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
daniel-beck
marked this pull request as ready for review
August 14, 2023 10:00
jglick
reviewed
Aug 14, 2023
jglick
left a comment
jglick
left a comment
Member
There was a problem hiding this comment.
Not sure I follow well enough to review seriously.
This comment was marked as resolved.
This comment was marked as resolved.
daniel-beck
marked this pull request as draft
August 14, 2023 20:51
daniel-beck
commented
Aug 22, 2023
daniel-beck
marked this pull request as draft
August 22, 2023 17:21
daniel-beck
marked this pull request as ready for review
August 25, 2023 09:32
This was referenced Sep 26, 2023
jglick
reviewed
Nov 1, 2023
jglick
left a comment
jglick
left a comment
Member
There was a problem hiding this comment.
Presuming someone else has done code review & testing on this & downstream, do you need a merge & release? It is not clear to me whether this is still a WiP or ready to go.
Member
Author
Thanks, just no good time IMO in the recent weeks. I'd like to be around for post-release support and ideally not simultaneously with another Stapler release. |
Member
Author
|
Last call for reviews :) |
timja
approved these changes
Feb 13, 2024
jglick
reviewed
Feb 13, 2024
jglick
left a comment
jglick
left a comment
Member
There was a problem hiding this comment.
Superficial comments, since I do not remember much about this system.
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-60866.
Currently,
st:bindgenerates inline JS. This doesn't work with CSP, so move that out.Additionally, add a new
StaplerRequest#createJavaScriptProxyParametersas replacement forStaplerRequest#createJavaScriptProxythat can be used without needing toevalthe result.Downstream PR: jenkinsci/jenkins#6865