[JENKINS-68933] Enable WebSocket - #240
Merged
Merged
Conversation
timja
approved these changes
Jul 6, 2022
basil
approved these changes
Jul 6, 2022
basil
left a comment
basil
left a comment
Member
There was a problem hiding this comment.
As noted in jenkinsci/jenkins#6785 (comment), I could imagine an argument for making this opt-in or opt-out based on command-line argument or system property, but in the absence of a specific use case the simple approach of having this always on seems like the best place to start. If a use case emerges where it is desirable to be able to turn off this functionality, I would be happy to add a command-line argument or system property to be able to disable it.
Member
|
Released in 6.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jenkinsci/jenkins#6785 (comment) says it all.