chore: update dependencies and align linting - #532
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThis PR refactors iCalendar parsing and timezone normalization, simplifies recurrence expansion and example control flow, updates tooling versions and lint rules, and strengthens related regression assertions. ChangesiCalendar recurrence maintenance
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This updates recurrence and tooling dependencies, refines iCalendar parsing and timezone handling, and preserves recurrence behavior through targeted regression assertions. No concrete merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The pull request updates rrule-temporal and states that it fixes issue Resolution Provide the resolved rrule-temporal version and confirm that the updated dependency prevents the YEARLY RRULE cross-product out-of-memory reproduction described in issue Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3a8a96c to
c1c98f4
Compare
|
I added a few more JSDoc comments to document the most important parser helpers, following CodeRabbit's feedback. Reaching the suggested 80% coverage would require documenting many internal helpers, tests, and build scripts, which feels out of scope for this PR. |
|
@jens-maus Did you noticed this PR? :) |
|
Sorry @KristjanESPERANTO. I am currently on vacation. So properly reviewing it will take some time. Hope that is fine for you. |
|
No problem at all! Enjoy your vacation 😃 |
c1c98f4 to
7a83b08
Compare
991d3cf to
66e530c
Compare
|
@coderabbitai resume |
✅ Action performedReviews resumed. |
66e530c to
41b3ed4
Compare
41b3ed4 to
8a66816
Compare
|
@jens-maus Are you still on vacation? 😎 |
This updates the project dependencies, including
rrule-temporal,xo,lint-staged, andmoment-timezone.The new
xoversion introduced a few new rules, so I addressed the resulting findings. I also used the opportunity to remove lint rules and overrides that are outdated or no longer relevant.This also fixes #542 with the new
rrule-temporalversion.Summary by CodeRabbit