fix: expand <rootDir> in filePathPrefix - #289
Closed
Adichapati wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the Jest <rootDir> placeholder inside filePathPrefix before it’s joined with each test file’s relative path, enabling absolute/monorepo-friendly file attribute output in generated JUnit JSON/XML.
Changes:
- Expand
<rootDir>infilePathPrefixvia the existingreplaceRootDirInOutputhelper before building per-testfilepath. - Add a unit test to validate
<rootDir>expansion behavior for the generatedtestcase._attr.filevalue.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utils/buildJsonResults.js | Expands <rootDir> in filePathPrefix prior to joining it with the test path. |
| tests/buildJsonResults.test.js | Adds coverage asserting <rootDir> expansion in filePathPrefix affects the emitted file attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
palmerj3
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Closes #256