Repository navigation
parity-oracles workflow: the suite against Jinja2 main, 3.0.3 and Python 3.13/3.14 (0186 phase 2) - #740
Merged
Conversation
…hon 3.13/3.14 (0186 phase 2) Nightly on master, on demand, and on pull requests that touch the oracle harness. Each row runs JINJA2CPP_TEST_ORACLE=venv and puts report.md in the job summary and an artifact; deltas are reported, not failed (decision O4). Locally: Jinja2 main agrees on all 2972 cases, Python 3.14 shows the 4 known stdlib deltas, all tracks-bundled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWNL7oJQzYFjjoGQPuDCF2
Member
Author
|
@codex review Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ruslan · project thread
Problem
Phase 1 (#725) lets a build run the parity suite against another Python Jinja2, but nothing runs it. Without a scheduled run, a behaviour change in Jinja2's next release, or in a newer Python, shows up only after users report it. This is phase 2 of the approved 0186 plan (section 5, revised in section 10). Phase 3 was dropped, so this PR closes 0186.
Resulting behaviour
New
.github/workflows/parity-oracles.yml, modelled onbindings.yml:generate.py,parity_test.cpp,requirements.txt,cmake/parity_oracle*.cmake, the workflow itself), nightly on master, and on demand.It has four rows, each using
JINJA2CPP_TEST_ORACLE=venvwith a gcc-14 Release build and one shared ccache key:jinja2 @ git+https://github.com/pallets/jinja@mainjinja2==3.0.3;markupsafe==2.1.5jinja2==3.1.6;markupsafe==3.0.3jinja2==3.1.6;markupsafe==3.0.3Where the two oracles agree, a case is judged by the allow-list as in every build job. A delta is only reported (decision O4):
report.mdgoes to the job summary and is uploaded as an artifact.test/parity/README.md, "Other oracles", describes the workflow. The 0186 task file records phase 2 and says this PR closes the task. The status line is left for the steward.
Validation
The same configurations were run locally on master 808cbdb (2972 cases):
tracks-bundledThe 3.14 deltas are the 4 that the plan measured on 3.13: two
\N{}name-rule cases andwordwrapm141/m142. The 3.0.3 row has 22 deltas on the 2850-case corpus, measured in Parity suite against another Python Jinja2: JINJA2CPP_TEST_ORACLE (0186 phase 1) #725.scripts/preflight.shandscripts/sbom.py --checkpass, and the workflow parses as YAML.This PR itself triggers the workflow through the
pathsfilter, so its CI run is the first real run.Process
Generated by Claude Code