Skip to content

fix: remove let support for now - #57

Merged
eddycharly merged 7 commits into
jmespath-community:mainfrom
eddycharly:rm-let
Mar 15, 2023
Merged

fix: remove let support for now#57
eddycharly merged 7 commits into
jmespath-community:mainfrom
eddycharly:rm-let

Conversation

@eddycharly

Copy link
Copy Markdown
Collaborator

This PR removes let support for now as the proposal is evolving into something different jmespath/jmespath.site#6

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly

Copy link
Copy Markdown
Collaborator Author

@springcomp WDYT ? Is it ok to remove let support until the proposal matures ?

@eddycharly
eddycharly requested a review from springcomp March 15, 2023 15:05
@codecov

codecov Bot commented Mar 15, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 91.66% and project coverage change: -0.40 ⚠️

Comparison is base (725e057) 80.01% compared to head (4e4d0c0) 79.61%.

❗ Current head 4e4d0c0 differs from pull request most recent head ea2bce5. Consider uploading reports for the commit ea2bce5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   80.01%   79.61%   -0.40%     
==========================================
  Files          14       13       -1     
  Lines        2547     2502      -45     
==========================================
- Hits         2038     1992      -46     
- Misses        418      420       +2     
+ Partials       91       90       -1     
Impacted Files Coverage Δ
pkg/functions/default.go 100.00% <ø> (ø)
pkg/functions/functions.go 61.65% <88.88%> (-0.02%) ⬇️
pkg/interpreter/functions.go 94.54% <100.00%> (ø)
pkg/interpreter/interpreter.go 75.00% <100.00%> (-1.12%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@springcomp

Copy link
Copy Markdown
Contributor

@springcomp WDYT ? Is it ok to remove let support until the proposal matures ?

Yes I think that’s reasonable.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
eddycharly marked this pull request as ready for review March 15, 2023 15:38
@eddycharly

Copy link
Copy Markdown
Collaborator Author

Yes I think that’s reasonable.

Cool, thanks.

@eddycharly
eddycharly merged commit f5d88db into jmespath-community:main Mar 15, 2023
@eddycharly
eddycharly deleted the rm-let branch March 15, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants