Skip to content

Carry the copyright and license header in the remaining file templates and in the PyPI wheel's generated modules #1591

Closed

Description

@jmrplens

#1563 gave every tracked source file the header, made the three Go generators and the create-mcp-tool skill's templates write it, and gated the tree with make check-file-headers. Two places that create source outside the tree it judges were left out.

Templates that still show a new file without the header

Each of these tells the reader to create a Go file and shows it opening directly with its package clause:

  • .github/skills/go-safe-move-refactor/SKILL.md: the minimal doc.go of step 3 (block at line 77) and ${dstDir}/action_specs.go of step 7 (block at line 165).
  • .github/skills/modularize-go-package/SKILL.md: ${sourcePackage}/{domain}/action_specs.go of step 3c (block at line 136).
  • docs/development/development.md, "Example: Adding a tools sub-package": internal/tools/branches/branches.go (line 438) and action_specs.go (line 464).

Each should open with the two header lines and a blank line, as the create-mcp-tool templates and docs/development/file-headers.md do. In the doc.go template the blank line matters, so the header is not read as the package comment.

The PyPI wheel's Python modules

scripts/build_pypi.py writes LAUNCHER (line 94) and MAIN_MODULE (line 143) into the published wheel as gitlab_mcp_server/__init__.py and gitlab_mcp_server/__main__.py, and neither carries the header. The "Generated files" section of docs/development/file-headers.md says the other generators write only documentation and data, which is not true of this one.

Done when

  • The four templates open with the header and a blank line.
  • Both wheel modules open with the header. Item 13 of Move the repository's Python, Node and shell tooling into Go commands under cmd/ #1114 ports build_pypi.py to a Go command, so the port writes it if it lands first; otherwise the Python script does.
  • docs/development/file-headers.md names the wheel modules among the generated source.
  • make check-file-headers, the Python script tests and markdownlint pass.

Activity

  1. added this to the 3.5.0 milestone on Oct 29, 2026
  2. added a commit that references this issue on Nov 1, 2026
    ce1a995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    v3.5.0Targeted at the 3.5.0 release

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions