Repository navigation
Reference correct source file and name in diagnostics in imported avdl files - #26
Merged
jonhoo merged 5 commits intoMay 12, 2026
Merged
Conversation
Reference stores a Span, which is later connected with the source and source_name of the root-file, giving confusing diagnostics for errors in imported files. This adds a test to prove this.
mrathelsing
force-pushed
the
mr/report-errors-in-imported-files
branch
from
May 7, 2026 21:32
493f67b to
3986395
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
jonhoo
approved these changes
May 8, 2026
The Arc would allocate would all be freed, just before the program exits, so leaking has no downside here
jonhoo
approved these changes
May 12, 2026
jonhoo
left a comment
Owner
There was a problem hiding this comment.
Approving since the last few bits are relatively minor/easy to fix
jonhoo
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References used to store a Span, which is later connected with the source and source_name of the root-file, giving confusing diagnostics for errors in imported files. The first commit adds a test to show this.The 2nd commit fixes it by making Arc's of source and source_name available throughout the visitor, stores those in the
References so they can be used to generate Warnings