Repository navigation
test doc comments in all possible positions - #29
Merged
Merged
Conversation
mrathelsing
force-pushed
the
mr/unsued-doc-on-enum-variants
branch
from
May 12, 2026 16:25
c678902 to
c8b0c84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
mrathelsing
force-pushed
the
mr/unsued-doc-on-enum-variants
branch
2 times, most recently
from
May 12, 2026 16:30
57c2626 to
4a570c3
Compare
jonhoo
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a test for doc comments in all possible positions.
Everything works as expected, except for doc comments on enum variants. They are ignored (and emit a warning) because the java app ignores them and the avro schema has no place for them.
See https://avro.apache.org/docs/1.12.0/specification/#enums