Skip to content

test doc comments in all possible positions - #29

Merged
jonhoo merged 1 commit into
jonhoo:mainfrom
mrathelsing:mr/unsued-doc-on-enum-variants
May 16, 2026
Merged

jonhoo merged 1 commit into
jonhoo:mainfrom
mrathelsing:mr/unsued-doc-on-enum-variants

Conversation

@mrathelsing

@mrathelsing mrathelsing commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

This adds a test for doc comments in all possible positions.
Everything works as expected, except for doc comments on enum variants. They are ignored (and emit a warning) because the java app ignores them and the avro schema has no place for them.
See https://avro.apache.org/docs/1.12.0/specification/#enums

@mrathelsing
mrathelsing force-pushed the mr/unsued-doc-on-enum-variants branch from c678902 to c8b0c84 Compare May 12, 2026 16:25
@codecov-commenter

codecov-commenter commented May 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.2%. Comparing base (3dbcdbd) to head (4a570c3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrathelsing
mrathelsing force-pushed the mr/unsued-doc-on-enum-variants branch 2 times, most recently from 57c2626 to 4a570c3 Compare May 12, 2026 16:30
@jonhoo
jonhoo merged commit 71e7f13 into jonhoo:main May 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants