Release epoch registry while waiting - #159
Open
mark0-cn wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
publishand writer teardown held the epoch-registry mutex throughout the reader wait loop. Creating or dropping aReadHandleneeds the same mutex. An active reader that tried to clone its handle could therefore wait on the writer while the writer waited for that reader's guard to be dropped.The writer now clones the registered
Arc<AtomicUsize>values while holding the mutex and waits on that stable snapshot after releasing it. Readers registered after the previous swap only observe the current read pointer, so they do not need to delay reuse of the older write-side copy. The mutex is reacquired around the next swap to capture every handle needed by the following wait cycle.This moves additional
Arcclone/drop work to each writer wait in exchange for keeping handle registration live while a reader is pinned.Validation
cargo test --offlinecargo fmt --all -- --checkRUSTFLAGS="--cfg loom" LOOM_MAX_PREEMPTIONS=3 cargo test --offline --release --test loom