Update of less compiler (leafo)

[dgrammatiko]

Joomla is using an outdated version of lessc

B/C

This should be 100% compatible with Bootstrap > 2.3 or any other less files that are using the same notation

Testing

Try to compile any less files (other than the ones Joomla is already shipping) and compare it with the previous copy. Should be identical.
It would be nice if you can apply #6979 and try to run generatecss.php, should work fine! Also since to already have applied that patch do some template switching and give to that one as well a response!

PS. There seems to be some border color clash for a sub template of Hathor, that needs some attention.
Protostar seems to get one more class for IE10, https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/responsive-utilities.less#L9-L11

[mbabker]

You have to run "composer update leafo/lessphp" and update the Composer
lock file too. Otherwise things start to get very out of whack.

Run "composer update leafo/lessphp" then "composer install --no-dev" after
changing the version constraint in composer.json. The second command
uninstalls the dev dependencies that will get pulled in (by design so they
are locked to specific versions for the CI systems).

On Wednesday, August 12, 2015, Dimitris Grammatiko notifications@github.com
wrote:

Joomla is using an outdated version of lessc B/C

This should be 100% compatible with Bootstrap > 2.3 or any other less
files that are using the same notation
Testing

Try to compile any less files (other than the ones Joomla is already
shipping) and compare it with the previous copy. Should be identical.

PS. There seems to be some border color clash for a sub template of
Hathor, that needs some attention.
Protostar seems to get one more class for IE7 (Useless Joomla supports

IE>8)

You can view, comment on, or merge this pull request online at:

#7687
Commit Summary

• Sync with leafo's repo ver 0.5

File Changes

• M administrator/templates/hathor/css/colour_brown.css
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-0 (106)
• M administrator/templates/hathor/less/colour_baseline.less
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-1 (32)
• M administrator/templates/hathor/less/colour_brown.less
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-2 (4)
• M administrator/templates/hathor/less/hathor_variables.less
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-3 (4)
• M administrator/templates/isis/css/template-rtl.css
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-4 (3)
• M administrator/templates/isis/css/template.css
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-5 (3)
• M libraries/cms/less/less.php
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-6 (32)
• M libraries/vendor/leafo/lessphp/LICENSE
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-7 (11)
• M libraries/vendor/leafo/lessphp/lessc.inc.php
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-8 (1284)
• M libraries/vendor/leafo/lessphp/lessify
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-9 (6)
• M libraries/vendor/leafo/lessphp/lessify.inc.php
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-10 (62)
• M libraries/vendor/leafo/lessphp/plessc
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-11 (4)
• M templates/beez3/css/turq.css
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-12 (1)
• M templates/protostar/css/template.css
  https://github.com/joomla/joomla-cms/pull/7687/files#diff-13 (3)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/7687.patch
• https://github.com/joomla/joomla-cms/pull/7687.diff

—
Reply to this email directly or view it on GitHub
#7687.

[wilsonge]

Joomla 3.x is IE8 and higher

[dgrammatiko]

@wilsonge that is quite a paradox bootstrap 2.x is >IE7 but Joomla is >IE8.
Anyway the extra class comes from bootstrap 2.x mixins which is IE7 compatible, so we either leave it as is, or we touch the bootstrap less

[dgrammatiko]

@mbabker done

[wilsonge]

https://docs.joomla.org/Joomla_Browser_Support

[dgrammatiko]

@wilsonge actually this -ms- class is for IE10: https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/responsive-utilities.less#L9-L11

[Bakual]

The reason why we never updated beyong 0.3.9 was the B/C warning for 0.4.0:
http://leafo.net/lessphp/changelog.html

Warning: this release has some breaking changes. If you the old selector expression syntax (eg. Bootstrap 2.3) then it’s recommended to use 0.3.9.

Interesting that on leafo.net, the latest version still shows as 0.4.0, while the 0.5.0 release is tagged in GitHub since Nov 2014.

[vess]

@Bakual Bootstrap moved away from that old selector expression before 0.4.0 even got out, so it should be ok to update our version.

[Bakual]

@Bakual Bootstrap moved away from that old selector expression before 0.4.0 even got out, so it should be ok to update our version.

I have no clue what it refers to. If Bootstrap 2.3.2 doesn't use that selector expression (whatever that is), then I guess we can safely update it.
However according to @nonumber in #6451 (comment), there are issues with 0.5.0.

[dgrammatiko]

@Bakual The errors @nonumber found are already been fixed in this PR (/cms/less/less.php)

v0.5.0 was not fine. Found issues with it (not inheriting overwritten variables)

Also @vess comment in another workgroup, which pointed to the fix:

multiple files in a row with the same instance fails... issue leafo/lessphp#594 fix that works is leafo/lessphp#607

[vess]

I have no clue what it refers to. If Bootstrap 2.3.2 doesn't use that selector expression (whatever that is), then I guess we can safely update it.

@Bakual
old: (~".span@{index}") {.span(@index);}
new: .span@{index} {.span(@index);}
lukeapage/bootstrap@6b9bb54

[Bakual]

Thanks!

[roland-d]

So are we OK to get this thing in or are there B/C concerns?

[dgrammatiko]

No B/C break with this

[roland-d]

In that case, this needs to be tested.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[RickR2H]

I have tested this item ✅ successfully on 657c027

Applied the patch and changed the .less files in the isis and the protostar template to monitor the output. After that executed generatecss.php to generate the stylesheets. Everything seems to work and there where no errors.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[joomla-cms-bot]

This PR has received new commits.

CC: @RickR2H

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[810]

I have tested this item ✅ successfully on 675a878

>=IE10 support has been ended by Microsoft. So we can also end the support for >= J3.5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[brianteeman]

(MS only ended support - they did not stop anyone from using it.)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[dgrammatiko]

@RickR2H can you retest this one? Thanks!

[RickR2H]

What is the best way to test this? I'll test asap ;)

[dgrammatiko]

Just run php build/generate.php and see if the css's are all ok

[RickR2H]

@DGT41 I'll do that.

Just for my information, why is the LESS compiler there when developers mostly use grunt etc. to compile less?

[dgrammatiko]

It has to be php, for the low end servers that don't have grunt etc

[810]

its php build/generatecss.php right not php build/generate.php

[dgrammatiko]

@810 yes you are right!

[RickR2H]

I have tested this item ✅ successfully on 675a878

Test was successful! To test it I added extra styling to the end of the template.less file. Sources are getting compiled nicely!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.}

[dgrammatiko]

RTC then