fix: report the actual function name in the non-angle Unit error of trig functions#3673
Open
greymoth-jp wants to merge 1 commit into
Open
fix: report the actual function name in the non-angle Unit error of trig functions#3673greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared
trigUnithelper hard-codescotin the "is no angle" error, so every function that uses it (sin,cos,tan,sec,csc, andcot) reportscotwhen it is given a unit that is not an angle. Five of the six name the wrong function:That should read "function sin". The message already follows the pattern "Unit in function is no angle", so the name just needs to come from the function that was actually called instead of being hard-coded to
cot. The fix reads it fromself.name, which resolves tosin,cos,tan,sec,csc, orcotdepending on which function the signature ends up in.All six trig functions had an "invalid unit" test that only checked that an error was thrown, never the message, so the wrong name went unnoticed. I tightened those assertions to also check the message. The five non-
cottests fail on the current code and pass with this change;cotwas already correct.