Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #762.
Ordinary tab presses suppress pointer propagation and compatibility mouse events, so ancestor listeners cannot dismiss an outside-click popup.
Allow ordinary pointer presses/releases to propagate and prevent mouse focus changes on
mousedown. Preserve touch compatibility-event cancellation and active-drag release suppression. Changes are intabbar.tsand its tests.Reproduction
mousedownlistener that hides the popup.Before: the listener does not dismiss the popup. After: it dismisses the popup while the input retains focus. Ancestors receive
pointerdown,mousedown,pointerup,mouseupandclick.Validation
WebKit and full JupyterLab were not tested. Cancelling
pointerdownsuppresses compatibilitymousedown; moving focus prevention tomousedownis necessary for mouse-based outside-click listeners.