Repository navigation
Conversation
The @insert_data_event_ and @delete_data_event_ decorators on insert_database and delete_from_database were commented out in Nov 2023 with no documented reason. The full event infrastructure is wired: decorator functions, monkey-patches in init_typedb_interface, and the event publisher all remain in place. Re-enabling requires only these two lines. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rezenders
force-pushed
the
fix/u3-reenable-events
branch
from
June 14, 2026 18:37
868014a to
6191947
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@insert_data_event_decorator oninsert_database@delete_data_event_decorator ondelete_from_database@pytest.mark.skip(reason='Events deactivated')fromtest_ros_typedb_insert_eventandtest_ros_typedb_delete_eventThe event infrastructure (decorator functions, monkey-patches in
init_typedb_interface, publisher creation,publish_data_eventmethod) was never removed — only the two decorator applications were commented out in commit3ea6012("🔥 not publishing events anymore", Nov 2023) with no explanation. All that was needed was to restore those two lines.Test plan
test_ros_typedb_insert_eventmust pass (previously skipped)test_ros_typedb_delete_eventmust pass (previously skipped)🤖 Generated with Claude Code