Repository navigation
feat: add error_message to Query.Response - #55
Merged
Merged
Conversation
When success=False, callers currently get no actionable failure reason — the error is logged server-side only. This adds: - string error_message field to Query.srv response - TypeDBInterface.last_error attribute, populated in every DB method except block, reset to '' at the start of each method - query_service_cb populates response.error_message from last_error on failure, or with 'Unknown query type: N' for unrecognised query types Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string error_messagetoQuery.srvresponse (afterbool success)TypeDBInterface.last_error: str = ''attribute, reset at the start of each DB method and populated withstr(err)in eachexceptblock (insert_database,update_database,delete_from_database,define_database,fetch_database,get_database,get_aggregate_database)query_service_cbnow setsresponse.error_message = self.typedb_interface.last_erroron failure, orf'Unknown query type: {req.query_type}'for unrecognised query typesTest plan
response.success is Falseandresponse.error_messageis non-emptyresponse.error_messageis''query_type:response.success is Falseanderror_messagecontains the type value🤖 Generated with Claude Code