Repository navigation
feat(app-store): animate.rise, row artwork whose cards rise out of the surface and sink back - #14
Merged
Merged
Conversation
animate: { rise: seconds } beside animate: { rows: seconds }. The rows stay put: cards come up
out of an empty surface and sink back a few at a time, each at the same moments of every loop,
so the loop closes. The look is the SVG's own. What is drawn through the mask fades in with its
card, and the file's filters (feOffset, feDropShadow, feGaussianBlur) grow with the card's
height, so a drop shadow lengthens as the card lifts. A card is drawn by itself once per height
and laid over the surface; cards that draw the same share their sprites, and the fade is
dithered in the blend so a faint card's gradient keeps its depth. With every card up the frame
is checked against the still, and art that fails says why.
fix(app-store): stills of row artwork with filters are drawn past the canvas and cropped, so the
shadow of a card cut by the canvas edge matches the others. Art without filters draws byte for
byte as before and keeps its cache key.
fix(cli): --set appStore.<placement>.animate.rows=20, as the README shows it, is accepted.
renderRows writes the mask region in canvas px with maskUnits="userSpaceOnUse", which a window
away from the source canvas needs when the source mask left the units out.
Contributor
|
Released as v1.7.0 and published to npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
animate: { rise: seconds }besideanimate: { rows: seconds }, for the header, search results and In-App Event videos.What it does
feOffset,feDropShadow,feGaussianBlur) grow with the card's height, so a drop shadow lengthens as the card lifts. A shape drawn on top inside one card comes up with it.Fixes found on the way
--set appStore.<placement>.animate.rows=20, as the README shows it, failed withUnknown --set path. It is accepted, withanimate.rise.renderRowswrites the mask region withmaskUnits="userSpaceOnUse".Measured
animate.rowsis unchanged: its 92 existing tests pass untouched, and TomoTV's In-App Event stills come out byte-identical.README (Cards that rise), schema and CHANGELOG are updated.