Report infrastructure failures as KCIDB ERROR#1513
Draft
nuclearcat wants to merge 1 commit into
Draft
Conversation
Use inherited Infrastructure error metadata when parsing test node status so nodes that were already marked fail by the runtime path still publish ERROR to KCIDB. This prevents infrastructure failures from being reported as test failures in KCIDB. This is a best-effort fix for the old discussion around issue kernelci#1087. I am not fully sure this is the correct final fix because that discussion happened a while ago and I do not remember all the details, so this should get maintainer review against the original failure modes. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use inherited Infrastructure error metadata when parsing test node status so nodes that were already marked fail by the runtime path still publish ERROR to KCIDB.
This prevents infrastructure failures from being reported as test failures in KCIDB.
This is a best-effort fix for the old discussion around issue #1087. I am not fully sure this is the correct final fix because that discussion happened a while ago and I do not remember all the details, so this should get maintainer review against the original failure modes.