Skip to content
This repository was archived by the owner on Mar 16, 2026. It is now read-only.

Relationship Values not clearing via admin API #4755

Open
millsy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Relationship Values not clearing via admin API #4755

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18a471e
Added session max age cookie to match keystone.uid cookie expiry
Feb 5, 2018
132e467
Moved check for null to allow clearing a value
Jul 31, 2018
2e87e41
Merge branch 'master' into master
autoboxer Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions fields/types/relationship/RelationshipType.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,7 @@ relationship.prototype.updateItem = function (item, data, callback) {
}

var value = this.getValueFromData(data);
if (value === undefined) {
return process.nextTick(callback);
}


// Are we handling a many relationship or just one value?
if (this.many) {
var arr = item.get(this.path);
Expand All @@ -244,7 +241,7 @@ relationship.prototype.updateItem = function (item, data, callback) {
if (value && value !== item.get(this.path)) {
// If it's set and has changed, I do.
item.set(this.path, value);
} else if (!value && item.get(this.path)) {
} else if ((value === undefined || !value) && item.get(this.path)) {
Comment thread
millsy marked this conversation as resolved.
// If it's not set and it was set previously, I need to clear.
item.set(this.path, null);
}
Expand Down