feat: Add Gloo Edge provider for basic VirtualService to HTTPRoute translation by shivansh-source · Pull Request #108 · kgateway-dev/ingress2gateway

shivansh-source · 2026-04-04T00:48:24Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR implements a new Gloo Edge provider for ingress2gateway that enables conversion of basic Gloo Edge VirtualService resources into Kubernetes Gateway API HTTPRoute manifests.

Features Implemented:

Read VirtualService CRDs from cluster or YAML file
Extract spec.hosts[] → map to HTTPRoute spec.hostnames[]
Extract spec.virtualHost.routes[] → map to HTTPRoute spec.rules[]
Support prefix-based path matching (matchers[].prefix → PathPrefix)
Reference upstreams in routeAction.single.upstream
Provider registration following ingress-nginx pattern
unit tests validating end-to-end conversion
Wired to cli
added test file to test the reading virtual service from yaml

Example Conversion

Input (Gloo Edge VirtualService):

apiVersion: gateway.solo.io/v1
kind: VirtualService
metadata:
  name: example-vs
  namespace: default
spec:
  hosts:
    - example.com
  virtualHost:
    routes:
      - matchers:
          - prefix: /api
        routeAction:
          single:
            upstream:
              name: my-service
              namespace: default

Output (Gateway API HTTPRoute):

apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: example-vs-example-com
  namespace: default
spec:
  hostnames:
    - example.com
  rules:
    - matches:
        - path:
            type: PathPrefix
            value: /api
      backendRefs:
        - name: my-service
          namespace: default

Files Changed:
Added pkg/i2gw/providers/glooedge/glooedge.go - Provider initialization
Added pkg/i2gw/providers/glooedge/types.go - Gloo Edge type definitions
Added pkg/i2gw/providers/glooedge/storage.go - Resource storage
Added pkg/i2gw/providers/glooedge/resource_reader.go - Read VirtualServices
Added pkg/i2gw/providers/glooedge/converter.go - Convert to Provider IR
Added pkg/i2gw/providers/glooedge/util.go - Helper utilities
Added pkg/i2gw/providers/glooedge/converter_test.go - Unit tests
Added pkg/i2gw/providers/glooedge/README.md - Provider documentation
Added test_virtualservice.yaml - Example VirtualService (delete later)

Which issue(s) this PR fixes:

Fixes #102

Add new Gloo Edge provider to ingress2gateway for converting Gloo Edge VirtualService resources to Kubernetes Gateway API HTTPRoute manifests. Supports basic routing with hosts, prefix-based path matching, and single upstream references.

Does this PR introduce a user-facing change?:

Add new Gloo Edge provider to ingress2gateway for converting Gloo Edge VirtualService resources to Kubernetes Gateway API HTTPRoute manifests. Supports basic routing with hosts, prefix-based path matching, and single upstream references.

…anslation Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

…tual service yaml for testing Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source · 2026-04-04T00:50:25Z

parent issue #107

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source · 2026-04-04T11:14:47Z

/cc @danehans

shivansh-source · 2026-04-06T18:15:31Z

all the previous problem from last pr has been solved in this pr

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

danehans · 2026-04-20T17:06:03Z

This PR does not properly fix issue #102. The new tests pass but it only covers the PR’s invented hosts model. In local end-to-end CLI checks, a real VirtualService fails to parse, and a non-default sample produces an unbindable HTTPRoute. Here are my suggestions to fix this PR:

Parse the real schema: spec.virtualHost.domains.
Read and resolve Upstream resources so single.upstream becomes Service name/namespace/port.
Keep Gateway and HTTPRoute namespace semantics consistent.
Add fixtures/tests for real Gloo manifests, discovered upstream names, and non-default namespaces.
Clean up docs: this PR adds pkg/i2gw/providers/glooedge/README .md with a stray space (should be pkg/i2gw/providers/glooedge/README.md,. The usage example says --provider and --output-file, but the actual CLI is --providers and has no --output-file; it prints to stdout instead.

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source · 2026-04-22T00:16:43Z

/cc @danehans ✅ Fixed README filename (no space) ✅ Fixed CLI docs (--providers, no --output-file) ✅ Parse spec.virtualHost.domains correctly ✅ Read and resolve Upstream resources ✅ Handle namespaces correctly (production, default) ✅ Comprehensive test cases with fixtures

shivansh-source · 2026-04-22T00:17:47Z

made example file inexamples/glooedge/ u can test in with them also added the test cases

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source · 2026-04-28T04:06:45Z

@danehans removed the shadow err mistake

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

…sult Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

danehans · 2026-04-29T17:55:09Z

The current CI failure is listener-order nondeterminism. The cause is in converter.go. The code stores listeners in a map and then materializes the slice with:

for _, listener := range listenersByNamespaceHost[namespace] {
    listeners = append(listeners, *listener)
}

Since listenersByNamespaceHost[namespace] is a Go map, that iteration order is undefined.

What I’d suggest:

Sort listeners before assigning gateway.Spec.Listeners, ideally by listener name or hostname.
Optionally also make the test sort both got and want before DeepEqual, but that should be secondary.

A simple fix would be:

hostKeys := make([]string, 0, len(listenersByNamespaceHost[namespace]))
for host := range listenersByNamespaceHost[namespace] {
    hostKeys = append(hostKeys, host)
}
slices.Sort(hostKeys)

listeners := make([]gatewayv1.Listener, 0, len(hostKeys))
for _, host := range hostKeys {
    listeners = append(listeners, *listenersByNamespaceHost[namespace][host])
}
gateway.Spec.Listeners = listeners

That matches our general pattern: the common converter already sorts map-derived keys before building output.

danehans · 2026-04-29T17:55:47Z

+}
+
+func readUpstreamsFromFile(_ io.Reader, _ string) ([]*Upstream, error) {
+	// TODO: Implement reading Upstreams from file


Upstream resolution needs to be implemented. Without it, storage.Upstreams is always empty, so we always fallback to emitting the upstream object’s own name with port: 0.

The reason this issue slips through tests is that the tests are encoding the broken behavior. The setup only adds a VirtualService to storage, not any Upstream. And several expectations explicitly assert port: 0, so the suite passes even though discovery/resolution never happens.

The fix I suggest is:

Implement real Upstream readers for file and optionally cluster (create a tracker issue if left unimplemented).

Extend types.go so Upstream carries the resolved Service identity, not just the upstream resource name. It should have fields like ServiceName, ServiceNamespace, and ServicePort.

Parse spec.kube.serviceName, serviceNamespace, and servicePort from Upstream resources.

In the converter, emit backendRefs from those resolved Service fields. If an Upstream can’t be resolved, return a conversion error or at least a warning instead of silently emitting port: 0.

Update tests to seed real Upstreams or use fixture-driven file reads, and assert outputs like petstore/default:8080 and users-api/production:9090.

got it i thought it could be implemented later

this is implemented now

danehans · 2026-04-29T17:56:01Z

+// NEW FUNCTIONS TO READ UPSTREAMS (like nginx reads Services)
+
+func readUpstreamsFromCluster(_ context.Context, _ interface{}) ([]*Upstream, error) {
+	// TODO: Implement reading Upstreams from cluster


Same as https://github.com/kgateway-dev/ingress2gateway/pull/108/changes#r3163093116

made a trackker issue for this #112

… Fixes: file-based Upstream reading for Gloo Edge migration Tracker: kgateway-dev#112 (cluster reading) Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

danehans · 2026-04-30T15:26:28Z

+	// TODO: Implement cluster reading for Upstreams using dynamic client
+	// For now, return empty list as fallback
+	// This would use client.Resource(upstreamGVR).List(ctx, metav1.ListOptions{})
+	return []*Upstream{}, nil


Since this is a stub return an error until it's implemented. Something like "“not supported yet, see issue #112”.

danehans · 2026-04-30T15:29:07Z

+					if !exists {
+						// Fallback: create basic upstream reference with port 0
+						upstream = &Upstream{
+							Name:      route.RouteAction.Single.Upstream.Name,
+							Namespace: route.RouteAction.Single.Upstream.Namespace,
+							Port:      0,
+						}
+					}


Fail fast on malformed Upstreams instead of producing port: 0.

danehans · 2026-04-30T15:33:54Z

+
+func (r *resourceReader) readResourcesFromFile(reader io.Reader) (*storage, error) {
+	storage := newResourcesStorage()
+	allResources, err := common.ExtractObjectsFromReader(reader, "")


Passing "" disables namespace filtering, so --namespace default still lets production objects through.

Add a regression test for this:

Input file contains one default VirtualService and one production VirtualService.

Run with ProviderConf.Namespace = "default".

Assert only the default resources make it into storage.

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source added 9 commits April 4, 2026 06:12

feat: Add Gloo Edge provider for basic VirtualService to HTTPRoute tr…

2b0e853

…anslation Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

added boilerplate in the file

6c547b1

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

again trying to see if ci works

4ad4e55

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

lf ending was the problem

4cbcdb6

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

wired provider to cli via blank import in cmd/root.go add example vir…

b3c2ec4

…tual service yaml for testing Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

wrong file it should be in print.go

edbf9d5

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

added asked changes

2b7cb79

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

done all changes

f598590

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

did some changes to converter.go

829f801

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source mentioned this pull request Apr 4, 2026

feat: Add Gloo Edge provider for basic VirtualService to HTTPRoute translation #105

Closed

final polish

364b95f

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source mentioned this pull request Apr 6, 2026

Gloo Edge Parity with Gloo #107

Open

62 tasks

shivansh-source temporarily deployed to release April 13, 2026 16:11 — with GitHub Actions Inactive

boilerplate fixed and linting fixed

ec33966

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source temporarily deployed to release April 20, 2026 03:03 — with GitHub Actions Inactive

read and resolve the upstream also added test cases to test

83958c8

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source temporarily deployed to release April 24, 2026 16:09 — with GitHub Actions Inactive

shadow err

834d62d

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source temporarily deployed to release April 28, 2026 04:46 — with GitHub Actions Inactive

fix: Resolve variable shadowing in resource_reader

605b6c3

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source temporarily deployed to release April 29, 2026 15:48 — with GitHub Actions Inactive

fix: Sort listeners deterministically in converter for stable test re…

b4bbf31

…sult Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

danehans reviewed Apr 29, 2026

View reviewed changes

shivansh-source mentioned this pull request Apr 30, 2026

Implement Real Upstream Reader for Cluster in Gloo Edge Provider #112

Open

5 tasks

Implement Upstream resource reading from files for Gloo Edge provider…

93a7e41

… Fixes: file-based Upstream reading for Gloo Edge migration Tracker: kgateway-dev#112 (cluster reading) Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

shivansh-source deployed to release April 30, 2026 15:03 — with GitHub Actions Active

danehans reviewed Apr 30, 2026

View reviewed changes

fixed some left issues

f61f88a

Signed-off-by: shivansh-source <shivanshsiddhi1234@gmail.com>

Uh oh!

Conversation

shivansh-source commented Apr 4, 2026

Features Implemented:

Example Conversion

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

Uh oh!

shivansh-source commented Apr 4, 2026

Uh oh!

shivansh-source commented Apr 4, 2026

Uh oh!

shivansh-source commented Apr 6, 2026

Uh oh!

danehans commented Apr 20, 2026

Uh oh!

shivansh-source commented Apr 22, 2026

Uh oh!

shivansh-source commented Apr 22, 2026

Uh oh!

shivansh-source commented Apr 28, 2026

Uh oh!

danehans commented Apr 29, 2026

Uh oh!

danehans Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

danehans Apr 29, 2026 •

edited

Loading