Skip to content

Migrate backend_protocol, backend_tls, and service_upstream tests to e2e #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asklokesh wants to merge 2 commits into
base: main
Choose a base branch
from
+802 −2
Open

Migrate backend_protocol, backend_tls, and service_upstream tests to e2e #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5640e87
fix: ignore buffer size annotations when proxy-buffering is disabled
asklokesh Jan 27, 2026
9de35ce
feat: migrate backend_protocol, backend_tls, and service_upstream to …
asklokesh Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/i2gw/emitters/kgateway/testing/testdata/input/golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ kind: Ingress
metadata:
annotations:
nginx.ingress.kubernetes.io/client-body-buffer-size: 10m
nginx.ingress.kubernetes.io/proxy-buffering: "on"
nginx.ingress.kubernetes.io/limit-rpm: "600"
nginx.ingress.kubernetes.io/proxy-send-timeout: "30s"
nginx.ingress.kubernetes.io/proxy-read-timeout: "45s"
Expand All @@ -29,6 +30,7 @@ kind: Ingress
metadata:
annotations:
nginx.ingress.kubernetes.io/client-body-buffer-size: 20m
nginx.ingress.kubernetes.io/proxy-buffering: "on"
nginx.ingress.kubernetes.io/limit-rps: "10"
nginx.ingress.kubernetes.io/proxy-send-timeout: "60" # No "s" suffix, should still be parsed correctly
nginx.ingress.kubernetes.io/proxy-read-timeout: "60" # No "s" suffix, should still be parsed correctly
Expand All @@ -54,9 +56,10 @@ kind: Ingress
metadata:
annotations:
nginx.ingress.kubernetes.io/client-body-buffer-size: 40m
nginx.ingress.kubernetes.io/proxy-body-size: "100m"
nginx.ingress.kubernetes.io/proxy-buffering: "on"
nginx.ingress.kubernetes.io/limit-rps: "50"
nginx.ingress.kubernetes.io/limit-burst-multiplier: "5"
nginx.ingress.kubernetes.io/proxy-body-size: "100m"
nginx.ingress.kubernetes.io/proxy-send-timeout: "90s"
nginx.ingress.kubernetes.io/proxy-read-timeout: "90s"
nginx.ingress.kubernetes.io/proxy-connect-timeout: "120"
Expand Down
12 changes: 11 additions & 1 deletion pkg/i2gw/providers/ingressnginx/bodybuffer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@ import (
"k8s.io/apimachinery/pkg/util/validation/field"
)

const clientBodyBufferSizeAnnotation = "nginx.ingress.kubernetes.io/client-body-buffer-size"
const (
clientBodyBufferSizeAnnotation = "nginx.ingress.kubernetes.io/client-body-buffer-size"
proxyBufferingAnnotation = "nginx.ingress.kubernetes.io/proxy-buffering"
)
Comment on lines +30 to +33

@danehans danehans Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I closed #64 as an invalid bug, so please remove commit 5640e87 from this PR.


// bufferPolicyFeature parses the "nginx.ingress.kubernetes.io/client-body-buffer-size" annotation
// from Ingresses and records them as generic Policies in the ingress-nginx provider-specific IR.
Expand All @@ -48,6 +51,13 @@ func bufferPolicyFeature(
continue
}

// Skip buffer size annotations when proxy-buffering is disabled or unset.
// Buffering is disabled by default in NGINX ingress controller.
bufferingEnabled := ing.Annotations[proxyBufferingAnnotation]
if bufferingEnabled != "on" {
continue
}

q, err := resource.ParseQuantity(val)
if err != nil {
errList = append(errList, field.Invalid(
Expand Down
Loading