Skip to content

Update and deny yanked dependencies - #3921

Merged
praseodym merged 2 commits into
mainfrom
fix-cargo-deny-yanked
Sep 8, 2026
Merged

praseodym merged 2 commits into
mainfrom
fix-cargo-deny-yanked

Conversation

@praseodym

@praseodym praseodym commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

What & why

How to test

Install cargo-deny, then cargo deny check in the backend directory should no longer report the yanked chacha20 dependency.

@praseodym praseodym self-assigned this Sep 8, 2026
@praseodym
praseodym requested a review from a team as a code owner September 8, 2026 07:20
@praseodym praseodym added dependencies Pull requests that update a dependency file backend Issues or pull requests that relate to the backend labels Sep 8, 2026
@praseodym praseodym moved this from Options to In Progress in Abacus Development Sep 8, 2026
@praseodym
praseodym enabled auto-merge September 8, 2026 07:28

@Lionqueen94 Lionqueen94 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cargo deny reports ok now

@oliver3
oliver3 self-requested a review September 8, 2026 07:51

@oliver3 oliver3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On main, cargo-deny check results in exit code 0 (echo $?) after warning about yanked crate chacha20

After adding yanked = "deny", it gives an error and returns exit code 1

@praseodym
praseodym added this pull request to the merge queue Sep 8, 2026
Merged via the queue into main with commit 99496f2 Sep 8, 2026
24 checks passed
@praseodym
praseodym deleted the fix-cargo-deny-yanked branch September 8, 2026 07:59
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Abacus Development Sep 8, 2026

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Issues or pull requests that relate to the backend dependencies Pull requests that update a dependency file

Projects

Development

Successfully merging this pull request may close these issues.

3 participants